You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "oscerd (via GitHub)" <gi...@apache.org> on 2026/04/08 07:38:27 UTC

[PR] CAMEL-23295: Fix resource leak and improve error handling in camel-splunk-hec producer [camel]

oscerd opened a new pull request, #22483:
URL: https://github.com/apache/camel/pull/22483

   ## Summary
   
   _Claude Code on behalf of Andrea Cosentino_
   
   - Add warning log when `skipTlsVerify` is enabled to alert operators that TLS verification is disabled
   - Replace generic `RuntimeException` with `RuntimeCamelException` for proper Camel error handling
   - Log error response body at DEBUG level for easier debugging of Splunk HEC failures
   - Consume response entity on success path to prevent potential connection leaks
   - Add unit tests for error handling behavior (3 new tests)
   
   Fixes: https://issues.apache.org/jira/browse/CAMEL-23295
   
   ## Test plan
   
   - [x] All existing tests pass (31 tests, 0 failures)
   - [x] New `SplunkHECProducerTest` verifies `RuntimeCamelException` is thrown on 400, 401, and 503 responses
   - [x] Verified exception type is `RuntimeCamelException` (not `RuntimeException`)
   
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23295: Fix resource leak and improve error handling in camel-splunk-hec producer [camel]

Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd merged PR #22483:
URL: https://github.com/apache/camel/pull/22483


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23295: Fix resource leak and improve error handling in camel-splunk-hec producer [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22483:
URL: https://github.com/apache/camel/pull/22483#issuecomment-4204689766

   <!-- ci-tested-modules -->
   :test_tube: **CI tested the following changed modules:**
   
   - `components/camel-splunk-hec`
   
   <details><summary>All tested modules (7 modules)</summary>
   
   - Camel :: JBang :: MCP
   - Camel :: JBang :: Plugin :: Route Parser
   - Camel :: JBang :: Plugin :: Validate
   - Camel :: Launcher :: Container
   - Camel :: Splunk HEC
   - Camel :: YAML DSL :: Validator
   - Camel :: YAML DSL :: Validator Maven Plugin
   
   </details>
   
   ---
   :gear: [View full build and test results](https://github.com/apache/camel/actions/runs/24123769505)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23295: Fix resource leak and improve error handling in camel-splunk-hec producer [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22483:
URL: https://github.com/apache/camel/pull/22483#issuecomment-4204600373

   :star2: Thank you for your contribution to the Apache Camel project! :star2:
     :robot: CI automation will test this PR automatically.
   
     :camel: Apache Camel Committers, please review the following items:
   
     * First-time contributors **require MANUAL approval** for the GitHub Actions to run
     * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
     * You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
     * Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
     
     :warning: Be careful when sharing logs. Review their contents before sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23295: Fix resource leak and improve error handling in camel-splunk-hec producer [camel]

Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #22483:
URL: https://github.com/apache/camel/pull/22483#issuecomment-4205226301

   _Claude Code on behalf of Andrea Cosentino_
   
   @gnodet Thank you for the review! Both items addressed in 3c5e848:
   
   1. **CamelContext cleanup** — Added `@AfterEach` with `camelContext.close()` to prevent resource leaks across test runs.
   2. **Redundant test** — Removed `testExceptionTypeIsRuntimeCamelExceptionNotRuntimeException` since the other two tests already verify the exception type via `assertThrows(RuntimeCamelException.class, ...)`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org