You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tuscany.apache.org by ri...@apache.org on 2006/08/22 16:48:28 UTC

svn commit: r433649 - /incubator/tuscany/java/sca/bindings/binding.axis2/src/main/java/org/apache/tuscany/binding/axis2/WebServiceBindingLoader.java

Author: rineholt
Date: Tue Aug 22 07:48:28 2006
New Revision: 433649

URL: http://svn.apache.org/viewvc?rev=433649&view=rev
Log:
improved error reporting

Modified:
    incubator/tuscany/java/sca/bindings/binding.axis2/src/main/java/org/apache/tuscany/binding/axis2/WebServiceBindingLoader.java

Modified: incubator/tuscany/java/sca/bindings/binding.axis2/src/main/java/org/apache/tuscany/binding/axis2/WebServiceBindingLoader.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/bindings/binding.axis2/src/main/java/org/apache/tuscany/binding/axis2/WebServiceBindingLoader.java?rev=433649&r1=433648&r2=433649&view=diff
==============================================================================
--- incubator/tuscany/java/sca/bindings/binding.axis2/src/main/java/org/apache/tuscany/binding/axis2/WebServiceBindingLoader.java (original)
+++ incubator/tuscany/java/sca/bindings/binding.axis2/src/main/java/org/apache/tuscany/binding/axis2/WebServiceBindingLoader.java Tue Aug 22 07:48:28 2006
@@ -115,6 +115,7 @@
             }
             // FIXME need to find out how to get wsdl and what context to use --- terrible hack attack!
             // URL wsdlurl = Thread.currentThread().getContextClassLoader().getResource(wsdlLocation);
+            if(null == wsdlLocation) throw new RuntimeException("Failed to determin wsdl location on binding. Try specifying 'location' attribute on  binding.");
             URL wsdlurl = deploymentContext.getClassLoader().getResource(wsdlLocation);
             if(wsdlurl == null) throw new RuntimeException("Failed to load wsdl from '" + wsdlLocation +"'" );
             



---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-commits-help@ws.apache.org


Re: svn commit: r433649

Posted by Jim Marino <jm...@myromatours.com>.
>              }
>              // FIXME need to find out how to get wsdl and what  
> context to use --- terrible hack attack!
>              // URL wsdlurl = Thread.currentThread 
> ().getContextClassLoader().getResource(wsdlLocation);
> +            if(null == wsdlLocation) throw new RuntimeException 
> ("Failed to determin wsdl location on binding. Try specifying  
> 'location' attribute on  binding.");
>
Hi Rick,

One more thing, we are always trying to extend exceptions from  
TuscanyRuntimeException or TuscanyException except when user code is  
involved. I think we should have a subtype of TuscanyRuntimeException  
in the binding extension that is more meaningful such as  
"LocationNotFoundException". Generally, the pattern we've been  
following in core is to have an abstract base exception per package  
which is part of the Tuscany(Runtime)Exception hierarchy (where it  
makes sense) that more specific exceptions subclass.

Jim


>              URL wsdlurl = deploymentContext.getClassLoader 
> ().getResource(wsdlLocation);
>              if(wsdlurl == null) throw new RuntimeException("Failed  
> to load wsdl from '" + wsdlLocation +"'" );
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-commits-help@ws.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org