You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/02/17 04:28:14 UTC
[GitHub] [kafka] C0urante opened a new pull request #11780: KAFKA-10000: Exactly-once source tasks
C0urante opened a new pull request #11780:
URL: https://github.com/apache/kafka/pull/11780
Implements a source task wrapper (`ExactlyOnceWorkerSourceTask`) that follows the behavior described in [KIP-618](https://cwiki.apache.org/confluence/display/KAFKA/KIP-618%3A+Exactly-Once+Support+for+Source+Connectors#KIP618:ExactlyOnceSupportforSourceConnectors-Atomicoffsetwrites) for writing source records and their offsets in transactions with user-configurable (and sometimes connector-defined) boundaries.
Relies on changes from:
- https://github.com/apache/kafka/pull/11772
- https://github.com/apache/kafka/pull/11773
- https://github.com/apache/kafka/pull/11775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante commented on a change in pull request #11780: KAFKA-10000: Exactly-once source tasks (KIP-618)
Posted by GitBox <gi...@apache.org>.
C0urante commented on a change in pull request #11780:
URL: https://github.com/apache/kafka/pull/11780#discussion_r808667916
##########
File path: connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java
##########
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.connect.storage;
+
+import org.apache.kafka.connect.runtime.WorkerConfig;
+import org.apache.kafka.connect.util.Callback;
+
+import java.nio.ByteBuffer;
+import java.util.Collection;
+import java.util.Map;
+import java.util.concurrent.Future;
+
+public class ConnectorOffsetBackingStore implements OffsetBackingStore {
Review comment:
This is a placeholder implementation. This class is fully implemented in the downstream PR https://github.com/apache/kafka/pull/11781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante commented on pull request #11780: KAFKA-10000: Exactly-once source tasks (KIP-618)
Posted by GitBox <gi...@apache.org>.
C0urante commented on pull request #11780:
URL: https://github.com/apache/kafka/pull/11780#issuecomment-1043994995
Converting to draft until upstream PRs are reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante commented on pull request #11780: KAFKA-10000: Exactly-once source tasks (KIP-618)
Posted by GitBox <gi...@apache.org>.
C0urante commented on pull request #11780:
URL: https://github.com/apache/kafka/pull/11780#issuecomment-1043508835
Jenkins build failures appear to be due to the issue addressed by https://github.com/apache/kafka/pull/10702. I've pushed a change that applies the same fix from that PR to the newly-added failing test classes for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org