You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/03/22 17:58:17 UTC
[GitHub] [lucene] madrob opened a new pull request #760: LUCENE-10481: FacetsCollector will not request scores if it does not use them
madrob opened a new pull request #760:
URL: https://github.com/apache/lucene/pull/760
LUCENE-10481: FacetsCollector will not request scores if it does not use them
# Description
When not collecting any documents, we don't need FacetsCollector to request scores.
# Checklist
Please review the following and check all that apply:
- [X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [X] I have created a Jira issue and added the issue ID to my pull request title.
- [X] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [X] I have developed this patch against the `main` branch.
- [X] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] madrob merged pull request #760: LUCENE-10481: FacetsCollector will not request scores if it does not use them
Posted by GitBox <gi...@apache.org>.
madrob merged pull request #760:
URL: https://github.com/apache/lucene/pull/760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] madrob commented on pull request #760: LUCENE-10481: FacetsCollector will not request scores if it does not use them
Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #760:
URL: https://github.com/apache/lucene/pull/760#issuecomment-1075437489
Local benchmarks showed a 2x improvement for facet counting when doing a search with filter queries. I'm attempting to replicate this using our existing lucene benchmarks, but they don't seem to have any non-scoring filters on facets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org