You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Evgeny Stanilovsky (Jira)" <ji...@apache.org> on 2023/05/11 06:22:00 UTC
[jira] [Updated] (IGNITE-19130) Sql. Align RexImpTable implementation according to calcite current version.

     [ https://issues.apache.org/jira/browse/IGNITE-19130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Evgeny Stanilovsky updated IGNITE-19130:
----------------------------------------
    Description: 
RexImpTable and RexToLixTranslator in apache ignite for now is a copy from outdated apache calcite, some functions already changed implementation and some additionally introduced (fow example ARG_MIN, ARG_MAX [1]) but apache ignite is not supported them due to outdated RexImpTable implementation. Propose: 
1. Somehow documented why we need such approach.
2. If only this way is convenient for now - copy actual implementation, change involved functions\fields access i.e. from private to protected and use\override appropriate methods in descendant implementation.

[1] https://issues.apache.org/jira/browse/CALCITE-5283

 

  was:
RexImpTable in apache ignite for now is a copy from old apache calcite, some functions already changed implementation and some additionally introduced (fow example ARG_MIN, ARG_MAX [1]) but apache ignite is not supported them due to outdated RexImpTable implementation. Propose: 
1. Somehow documented why we need such approach.
2. If only this way is convenient for now - copy actual implementation, change involved functions\fields access i.e. from private to protected and use\override appropriate methods in descendant implementation.

[1] https://issues.apache.org/jira/browse/CALCITE-5283

 

The same issue seems need to be raised for RexToLixTranslator implementation.


> Sql. Align RexImpTable implementation according to calcite current version.
> ---------------------------------------------------------------------------
>
>                 Key: IGNITE-19130
>                 URL: https://issues.apache.org/jira/browse/IGNITE-19130
>             Project: Ignite
>          Issue Type: Improvement
>          Components: sql
>    Affects Versions: 3.0.0-beta1
>            Reporter: Evgeny Stanilovsky
>            Assignee: Evgeny Stanilovsky
>            Priority: Major
>              Labels: calcite3-required, ignite-3
>
> RexImpTable and RexToLixTranslator in apache ignite for now is a copy from outdated apache calcite, some functions already changed implementation and some additionally introduced (fow example ARG_MIN, ARG_MAX [1]) but apache ignite is not supported them due to outdated RexImpTable implementation. Propose: 
> 1. Somehow documented why we need such approach.
> 2. If only this way is convenient for now - copy actual implementation, change involved functions\fields access i.e. from private to protected and use\override appropriate methods in descendant implementation.
> [1] https://issues.apache.org/jira/browse/CALCITE-5283
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)