You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jason810496 (via GitHub)" <gi...@apache.org> on 2024/11/25 12:28:21 UTC
[PR] AIP-84 Refactor SortParm [airflow]
jason810496 opened a new pull request, #44345:
URL: https://github.com/apache/airflow/pull/44345
Related: https://github.com/apache/airflow/pull/42959#issuecomment-2422749143
### Refactor `SortParam`
Leverage the `to_replace` functionality introduced in https://github.com/apache/airflow/pull/43793 and allow the `Column` type to be used in the `to_replace` dictionary.
This change enables the complete removal of `attr_mapping` from `SortParam`, as most instances of `SortParam` do not require `attr_mapping`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AIP-84 Refactor SortParm [airflow]
Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 commented on PR #44345:
URL: https://github.com/apache/airflow/pull/44345#issuecomment-2501397318
Just adapt https://github.com/apache/airflow/pull/44393 to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AIP-84 Refactor SortParm [airflow]
Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 commented on PR #44345:
URL: https://github.com/apache/airflow/pull/44345#issuecomment-2500750641
Resolve conflict, wait for CI ⚙️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AIP-84 Refactor SortParm [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun merged PR #44345:
URL: https://github.com/apache/airflow/pull/44345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AIP-84 Refactor SortParm [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #44345:
URL: https://github.com/apache/airflow/pull/44345#issuecomment-2500113316
Need to resolve conflicts. Good to merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org