You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "guilhem-depop (via GitHub)" <gi...@apache.org> on 2023/07/28 11:07:21 UTC
[GitHub] [spark] guilhem-depop opened a new pull request, #42207: [SPARK-XXXX][MLLIB] Fix warning condition in MLLib RankingMetrics ndcgAk
guilhem-depop opened a new pull request, #42207:
URL: https://github.com/apache/spark/pull/42207
### What changes were proposed in this pull request?
This PR fixes the condition to raise the following warning in MLLib's RankingMetrics ndcgAk function: "# of ground truth set and # of relevance value set should be equal, check input data"
The logic for raising warnings is faulty at the moment: it raises a warning if the `rel` input is empty and `lab.size` and `rel.size` are not equal.
The logic should be to raise a warning if `rel` input is **not empty** and `lab.size` and `rel.size` are not equal.
### Why are the changes needed?
With the current logic, RankingMetrics will:
- raise incorrect warning when a user is using it in the "binary" mode (i.e. no relevance values in the input)
- not raise warning (that could be necessary) when the user is using it in the "non-binary" model (i.e. with relevance values in the input)
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
No change made to the test suite for RankingMetrics: https://github.com/uchiiii/spark/blob/a172172329cc78b50f716924f2a344517deb71fc/mllib/src/test/scala/org/apache/spark/mllib/evaluation/RankingMetricsSuite.scala
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #42207: [SPARK-44585][MLLIB] Fix warning condition in MLLib RankingMetrics ndcgAk
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen closed pull request #42207: [SPARK-44585][MLLIB] Fix warning condition in MLLib RankingMetrics ndcgAk
URL: https://github.com/apache/spark/pull/42207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #42207: [SPARK-44585][MLLIB] Fix warning condition in MLLib RankingMetrics ndcgAk
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #42207:
URL: https://github.com/apache/spark/pull/42207#issuecomment-1656400641
Merged to master/3.5/3.4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #42207: [SPARK-XXXX][MLLIB] Fix warning condition in MLLib RankingMetrics ndcgAk
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #42207:
URL: https://github.com/apache/spark/pull/42207#issuecomment-1655538856
Looks OK, but please enable GH tests in your fork to run them
https://github.com/apache/spark/pull/42207/checks?check_run_id=15426146826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] guilhem-depop commented on pull request #42207: [SPARK-44585][MLLIB] Fix warning condition in MLLib RankingMetrics ndcgAk
Posted by "guilhem-depop (via GitHub)" <gi...@apache.org>.
guilhem-depop commented on PR #42207:
URL: https://github.com/apache/spark/pull/42207#issuecomment-1655679796
@srowen here's the ticket: https://issues.apache.org/jira/browse/SPARK-44585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] guilhem-depop commented on pull request #42207: [SPARK-XXXX][MLLIB] Fix warning condition in MLLib RankingMetrics ndcgAk
Posted by "guilhem-depop (via GitHub)" <gi...@apache.org>.
guilhem-depop commented on PR #42207:
URL: https://github.com/apache/spark/pull/42207#issuecomment-1655509297
FYI @uchiiii @srowen (since you implemented/reviewed https://github.com/apache/spark/pull/36843)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #42207: [SPARK-XXXX][MLLIB] Fix warning condition in MLLib RankingMetrics ndcgAk
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #42207:
URL: https://github.com/apache/spark/pull/42207#issuecomment-1655539263
Also, this needs a JIRA, and needs to be connected in the title
https://spark.apache.org/contributing.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org