You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Rich Bowen <rb...@rcbowen.com> on 2007/08/10 14:54:59 UTC

Re: Conditional RequestHeader patch not reflected in documentation?

Received this query from a friend and colleague:

> ... I've been working on an issue at
> work, where we're trying to remove some headers from a (proxied)
> request.  Whilst I was looking for a solution I came across this
> patch:
>
> http://mail-archives.apache.org/mod_mbox/httpd-cvs/200406.mbox/% 
> 3C20040606221938.13736.qmail@minotaur.apache.org%3E
>
> but when I looked at the mod_headers docs -
> http://httpd.apache.org/docs/2.0/mod/mod_headers.html
>
> I can't see anything about it.
>
> I was wondering if the patch was reversed or wasn't used, or whether
> the documentation was behind.


Looking at the code, I'm not entirely certain if the patch is in  
there or not. The removed lines are missing, but so are the added  
lines. Can someone shed any light on this for me, please? Or is this  
so long ago that it's no longer answerable?

--
http://feathercast.org/




Re: Conditional RequestHeader patch not reflected in documentation?

Posted by Joshua Slive <jo...@slive.ca>.
On 8/10/07, Rich Bowen <rb...@rcbowen.com> wrote:
> Received this query from a friend and colleague:
>
> > ... I've been working on an issue at
> > work, where we're trying to remove some headers from a (proxied)
> > request.  Whilst I was looking for a solution I came across this
> > patch:
> >
> > http://mail-archives.apache.org/mod_mbox/httpd-cvs/200406.mbox/%
> > 3C20040606221938.13736.qmail@minotaur.apache.org%3E
> >
> > but when I looked at the mod_headers docs -
> > http://httpd.apache.org/docs/2.0/mod/mod_headers.html
> >
> > I can't see anything about it.
> >
> > I was wondering if the patch was reversed or wasn't used, or whether
> > the documentation was behind.
>
>
> Looking at the code, I'm not entirely certain if the patch is in
> there or not. The removed lines are missing, but so are the added
> lines. Can someone shed any light on this for me, please? Or is this
> so long ago that it's no longer answerable?

From
http://svn.apache.org/repos/asf/httpd/httpd/branches/2.0.x/modules/metadata/mod_headers.c
it looks like it is in there to me. (Header and RequestHeader
processing are identical.) The docs just never got backported to 2.0.

Joshua.

Re: Conditional RequestHeader patch not reflected in documentation?

Posted by Rich Bowen <rb...@rcbowen.com>.
On Aug 10, 2007, at 16:31, Vincent Deffontaines wrote:
>>>
>>> http://mail-archives.apache.org/mod_mbox/httpd-cvs/200406.mbox/% 
>>> 3C20040606221938.13736.qmail@minotaur.apache.org%3E
>>>
> I am the original author of the patch, which André applied.
> Shortly after the patch was accepted in 2.0, I sent a documentation  
> patch for 2.0.
> Reply I got was that 2.0 documentation was not important, and doc
> patch would not be applied.
> As far as I know, the patch *is* applied on 2.0.

I'm very sorry that was the response that you received. The 2.0  
documentation is, of course, important. If you can direct me to that  
patch, I'd be glad to apply it.

--
Whatever you do will be insignificant, but it is very important that  
you do it.
Mahatma Ghandi




---------------------------------------------------------------------
To unsubscribe, e-mail: docs-unsubscribe@httpd.apache.org
For additional commands, e-mail: docs-help@httpd.apache.org


Re: Conditional RequestHeader patch not reflected in documentation?

Posted by Rich Bowen <rb...@rcbowen.com>.
On Aug 10, 2007, at 16:31, Vincent Deffontaines wrote:
>>>
>>> http://mail-archives.apache.org/mod_mbox/httpd-cvs/200406.mbox/% 
>>> 3C20040606221938.13736.qmail@minotaur.apache.org%3E
>>>
> I am the original author of the patch, which André applied.
> Shortly after the patch was accepted in 2.0, I sent a documentation  
> patch for 2.0.
> Reply I got was that 2.0 documentation was not important, and doc
> patch would not be applied.
> As far as I know, the patch *is* applied on 2.0.

I'm very sorry that was the response that you received. The 2.0  
documentation is, of course, important. If you can direct me to that  
patch, I'd be glad to apply it.

--
Whatever you do will be insignificant, but it is very important that  
you do it.
Mahatma Ghandi




Re: Conditional RequestHeader patch not reflected in documentation?

Posted by Vincent Deffontaines <vi...@gryzor.com>.
Rich Bowen wrote:
> Received this query from a friend and colleague:
>
>> ... I've been working on an issue at
>> work, where we're trying to remove some headers from a (proxied)
>> request.  Whilst I was looking for a solution I came across this
>> patch:
>>
>> http://mail-archives.apache.org/mod_mbox/httpd-cvs/200406.mbox/%3C20040606221938.13736.qmail@minotaur.apache.org%3E 
>>
>>
>> but when I looked at the mod_headers docs -
>> http://httpd.apache.org/docs/2.0/mod/mod_headers.html
>>
>> I can't see anything about it.
>>
>> I was wondering if the patch was reversed or wasn't used, or whether
>> the documentation was behind.
>

Greetings,

I am the original author of the patch, which André applied.
Shortly after the patch was accepted in 2.0, I sent a documentation 
patch for 2.0.
Reply I got was that 2.0 documentation was not important, and doc
patch would not be applied.
As far as I know, the patch *is* applied on 2.0.


BR,

Vincent Deffontaines


>
> Looking at the code, I'm not entirely certain if the patch is in there 
> or not. The removed lines are missing, but so are the added lines. Can 
> someone shed any light on this for me, please? Or is this so long ago 
> that it's no longer answerable?
>
> -- 
> http://feathercast.org/
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: docs-unsubscribe@httpd.apache.org
> For additional commands, e-mail: docs-help@httpd.apache.org
>


Re: Conditional RequestHeader patch not reflected in documentation?

Posted by Vincent Deffontaines <vi...@gryzor.com>.
Rich Bowen wrote:
> Received this query from a friend and colleague:
>
>> ... I've been working on an issue at
>> work, where we're trying to remove some headers from a (proxied)
>> request.  Whilst I was looking for a solution I came across this
>> patch:
>>
>> http://mail-archives.apache.org/mod_mbox/httpd-cvs/200406.mbox/%3C20040606221938.13736.qmail@minotaur.apache.org%3E 
>>
>>
>> but when I looked at the mod_headers docs -
>> http://httpd.apache.org/docs/2.0/mod/mod_headers.html
>>
>> I can't see anything about it.
>>
>> I was wondering if the patch was reversed or wasn't used, or whether
>> the documentation was behind.
>

Greetings,

I am the original author of the patch, which André applied.
Shortly after the patch was accepted in 2.0, I sent a documentation 
patch for 2.0.
Reply I got was that 2.0 documentation was not important, and doc
patch would not be applied.
As far as I know, the patch *is* applied on 2.0.


BR,

Vincent Deffontaines


>
> Looking at the code, I'm not entirely certain if the patch is in there 
> or not. The removed lines are missing, but so are the added lines. Can 
> someone shed any light on this for me, please? Or is this so long ago 
> that it's no longer answerable?
>
> -- 
> http://feathercast.org/
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: docs-unsubscribe@httpd.apache.org
> For additional commands, e-mail: docs-help@httpd.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: docs-unsubscribe@httpd.apache.org
For additional commands, e-mail: docs-help@httpd.apache.org