You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/24 10:16:20 UTC
[GitHub] [incubator-shardingsphere] yu199195 opened a new pull request
#4920: default-data-source-name Spelling mistakes.
yu199195 opened a new pull request #4920: default-data-source-name Spelling mistakes.
URL: https://github.com/apache/incubator-shardingsphere/pull/4920
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4920:
default-data-source-name Spelling mistakes.
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4920: default-data-source-name Spelling mistakes.
URL: https://github.com/apache/incubator-shardingsphere/pull/4920
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull
request #4920: default-data-source-name Spelling mistakes.
Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #4920: default-data-source-name Spelling mistakes.
URL: https://github.com/apache/incubator-shardingsphere/pull/4920#discussion_r397052431
##########
File path: examples/sharding-jdbc-example/orchestration-example/orchestration-spring-boot-example/src/main/resources/application-local-zookeeper-sharding-databases-tables.properties
##########
@@ -35,7 +35,7 @@ spring.shardingsphere.sharding.default-database-strategy.inline.sharding-column=
spring.shardingsphere.sharding.default-database-strategy.inline.algorithm-expression=ds_$->{user_id % 2}
spring.shardingsphere.sharding.binding-tables=t_order,t_order_item
-spring.shardingsphere.sharding.default-datasource-name=ds_0
+spring.shardingsphere.sharding.default-data-source-name=ds_0
Review comment:
why?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull
request #4920: default-data-source-name Spelling mistakes.
Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #4920: default-data-source-name Spelling mistakes.
URL: https://github.com/apache/incubator-shardingsphere/pull/4920#discussion_r397052431
##########
File path: examples/sharding-jdbc-example/orchestration-example/orchestration-spring-boot-example/src/main/resources/application-local-zookeeper-sharding-databases-tables.properties
##########
@@ -35,7 +35,7 @@ spring.shardingsphere.sharding.default-database-strategy.inline.sharding-column=
spring.shardingsphere.sharding.default-database-strategy.inline.algorithm-expression=ds_$->{user_id % 2}
spring.shardingsphere.sharding.binding-tables=t_order,t_order_item
-spring.shardingsphere.sharding.default-datasource-name=ds_0
+spring.shardingsphere.sharding.default-data-source-name=ds_0
Review comment:
why?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services