You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by li...@apache.org on 2018/08/01 10:10:15 UTC

[incubator-servicecomb-java-chassis] 01/06: [SCB-790] resolve eclipse compile warnings

This is an automated email from the ASF dual-hosted git repository.

liubao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-servicecomb-java-chassis.git

commit 7ff9f6d7138031d4f649c56e2da0487e4ccfaf67
Author: wujimin <wu...@huawei.com>
AuthorDate: Tue Jul 31 11:09:11 2018 +0800

    [SCB-790] resolve eclipse compile warnings
---
 .../common/rest/codec/AbstractRestObjectMapper.java            |  2 ++
 .../apache/servicecomb/common/rest/codec/RestObjectMapper.java |  1 -
 .../test/java/org/apache/servicecomb/core/TestExecutors.java   |  2 +-
 demo/demo-jaxrs/jaxrs-server/pom.xml                           |  1 -
 .../servicecomb/demo/RestObjectMapperWithStringMapper.java     |  3 ++-
 demo/pom.xml                                                   | 10 ----------
 .../arguments/consumer/ConsumerArgumentsMapperFactory.java     |  1 -
 .../arguments/producer/ProducerArgumentsMapperFactory.java     |  1 -
 8 files changed, 5 insertions(+), 16 deletions(-)

diff --git a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/AbstractRestObjectMapper.java b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/AbstractRestObjectMapper.java
index 8a7ab0e..0ca5fa6 100644
--- a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/AbstractRestObjectMapper.java
+++ b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/AbstractRestObjectMapper.java
@@ -20,5 +20,7 @@ package org.apache.servicecomb.common.rest.codec;
 import com.fasterxml.jackson.databind.ObjectMapper;
 
 public abstract class AbstractRestObjectMapper extends ObjectMapper {
+  private static final long serialVersionUID = 189026839992490564L;
+
   abstract public String convertToString(Object value) throws Exception;
 }
diff --git a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/RestObjectMapper.java b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/RestObjectMapper.java
index 617e86b..f94ec2c 100644
--- a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/RestObjectMapper.java
+++ b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/RestObjectMapper.java
@@ -26,7 +26,6 @@ import com.fasterxml.jackson.core.JsonParser.Feature;
 import com.fasterxml.jackson.databind.DeserializationFeature;
 import com.fasterxml.jackson.databind.JavaType;
 import com.fasterxml.jackson.databind.JsonSerializer;
-import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.SerializationFeature;
 import com.fasterxml.jackson.databind.SerializerProvider;
 import com.fasterxml.jackson.databind.module.SimpleModule;
diff --git a/core/src/test/java/org/apache/servicecomb/core/TestExecutors.java b/core/src/test/java/org/apache/servicecomb/core/TestExecutors.java
index 8d64571..22f933c 100644
--- a/core/src/test/java/org/apache/servicecomb/core/TestExecutors.java
+++ b/core/src/test/java/org/apache/servicecomb/core/TestExecutors.java
@@ -50,12 +50,12 @@ public class TestExecutors {
 
     ReactiveExecutor oReactiveExecutor = new ReactiveExecutor();
     oReactiveExecutor.execute(new Runnable() {
-
       @Override
       public void run() {
         strThreadTest = "thread Ran";
       }
     });
+    oReactiveExecutor.close();
     Assert.assertEquals("thread Ran", strThreadTest);
   }
 }
diff --git a/demo/demo-jaxrs/jaxrs-server/pom.xml b/demo/demo-jaxrs/jaxrs-server/pom.xml
index 48c726d..449e611 100644
--- a/demo/demo-jaxrs/jaxrs-server/pom.xml
+++ b/demo/demo-jaxrs/jaxrs-server/pom.xml
@@ -40,7 +40,6 @@
     <dependency>
       <groupId>org.glassfish.jersey.core</groupId>
       <artifactId>jersey-client</artifactId>
-      <version>2.25.1</version>
     </dependency>
     <dependency>
       <groupId>org.apache.servicecomb</groupId>
diff --git a/demo/demo-schema/src/main/java/org/apache/servicecomb/demo/RestObjectMapperWithStringMapper.java b/demo/demo-schema/src/main/java/org/apache/servicecomb/demo/RestObjectMapperWithStringMapper.java
index 49a247f..d90160c 100644
--- a/demo/demo-schema/src/main/java/org/apache/servicecomb/demo/RestObjectMapperWithStringMapper.java
+++ b/demo/demo-schema/src/main/java/org/apache/servicecomb/demo/RestObjectMapperWithStringMapper.java
@@ -44,9 +44,10 @@ import com.fasterxml.jackson.databind.JavaType;
  *  conversion change. You must write  convertValue to check possible types using.
  */
 public class RestObjectMapperWithStringMapper extends RestObjectMapper {
+  private static final long serialVersionUID = 4279371572149490568L;
+
   private static Logger LOGGER = LoggerFactory.getLogger(RestObjectMapperWithStringMapper.class);
 
-  @SuppressWarnings("deprecation")
   public RestObjectMapperWithStringMapper() {
     super();
   }
diff --git a/demo/pom.xml b/demo/pom.xml
index 8490f68..b1a7bc8 100644
--- a/demo/pom.xml
+++ b/demo/pom.xml
@@ -177,16 +177,6 @@
         </plugin>
       </plugins>
     </pluginManagement>
-    <plugins>
-      <plugin>
-        <groupId>org.sonatype.plugins</groupId>
-        <artifactId>nexus-staging-maven-plugin</artifactId>
-        <extensions>true</extensions>
-        <configuration>
-          <skipStaging>true</skipStaging>
-        </configuration>
-      </plugin>
-    </plugins>
   </build>
 
   <profiles>
diff --git a/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/arguments/consumer/ConsumerArgumentsMapperFactory.java b/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/arguments/consumer/ConsumerArgumentsMapperFactory.java
index 54a69ca..0a72be0 100644
--- a/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/arguments/consumer/ConsumerArgumentsMapperFactory.java
+++ b/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/arguments/consumer/ConsumerArgumentsMapperFactory.java
@@ -44,7 +44,6 @@ public class ConsumerArgumentsMapperFactory extends ArgumentsMapperFactory<Consu
     createFactoryMap(factoryList);
   }
 
-  @SuppressWarnings("unchecked")
   @Override
   public ConsumerArgumentsMapper createArgumentsMapper(ArgumentsMapperConfig config) {
     collectArgumentsMapper(config);
diff --git a/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/arguments/producer/ProducerArgumentsMapperFactory.java b/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/arguments/producer/ProducerArgumentsMapperFactory.java
index 4babe00..3423bed 100644
--- a/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/arguments/producer/ProducerArgumentsMapperFactory.java
+++ b/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/arguments/producer/ProducerArgumentsMapperFactory.java
@@ -60,7 +60,6 @@ public class ProducerArgumentsMapperFactory extends ArgumentsMapperFactory<Produ
     createFactoryMap(factoryList);
   }
 
-  @SuppressWarnings("unchecked")
   @Override
   public ProducerArgumentsMapper createArgumentsMapper(ArgumentsMapperConfig config) {
     collectArgumentsMapper(config);