You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/06 04:00:08 UTC
[GitHub] [doris] XieJiann opened a new pull request, #15672: [fix](Nereids): Add varchar literal compare
XieJiann opened a new pull request, #15672:
URL: https://github.com/apache/doris/pull/15672
Signed-off-by: xiejiann <ji...@gmail.com>
# Proposed changes
support "1" = "123"
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] XieJiann commented on pull request #15672: [fix](Nereids): Add varchar literal compare
Posted by GitBox <gi...@apache.org>.
XieJiann commented on PR #15672:
URL: https://github.com/apache/doris/pull/15672#issuecomment-1375210059
> add regression test and ut
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15672: [fix](Nereids): Add varchar literal compare
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15672:
URL: https://github.com/apache/doris/pull/15672#issuecomment-1373160735
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.95 seconds
load time: 651 seconds
storage size: 17123213298 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230106052418_clickbench_pr_74611.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] XieJiann closed pull request #15672: [fix](Nereids): Add varchar literal compare
Posted by GitBox <gi...@apache.org>.
XieJiann closed pull request #15672: [fix](Nereids): Add varchar literal compare
URL: https://github.com/apache/doris/pull/15672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] XieJiann commented on pull request #15672: [fix](Nereids): Add varchar literal compare
Posted by GitBox <gi...@apache.org>.
XieJiann commented on PR #15672:
URL: https://github.com/apache/doris/pull/15672#issuecomment-1375209746
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15672: [fix](Nereids): Add varchar literal compare
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15672:
URL: https://github.com/apache/doris/pull/15672#issuecomment-1376674689
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #15672: [fix](Nereids): Add varchar literal compare
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #15672:
URL: https://github.com/apache/doris/pull/15672#discussion_r1066162116
##########
regression-test/suites/nereids_syntax_p0/function.groovy:
##########
@@ -103,5 +103,10 @@ suite("nereids_function") {
sql "select convert_to('abc', cast(number as varchar)) from numbers('number'='1')"
exception "must be a constant"
}
+
+ test {
+ sql """select "1" == "123", "%%" == "%%" """
Review Comment:
nit: we need remove syntax `1 == 3`, legacy planner only support `1 = 3`, please fix it in another PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15672: [fix](Nereids): Add varchar literal compare
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15672:
URL: https://github.com/apache/doris/pull/15672#issuecomment-1376674711
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15672: [fix](Nereids): Add varchar literal compare
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15672:
URL: https://github.com/apache/doris/pull/15672#issuecomment-1377687393
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow merged pull request #15672: [fix](Nereids): Add varchar literal compare
Posted by GitBox <gi...@apache.org>.
morrySnow merged PR #15672:
URL: https://github.com/apache/doris/pull/15672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org