You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/03/29 09:18:04 UTC
[GitHub] [hudi] codope opened a new pull request #5166: [MINOR] Fix dates as per UTC in TestDataSkippingUtils
codope opened a new pull request #5166:
URL: https://github.com/apache/hudi/pull/5166
## What is the purpose of the pull request
In `TestDataSkippingUtils`, we are instantiating [Timestamp](https://docs.oracle.com/javase/8/docs/api/java/sql/Timestamp.html#Timestamp-long-) which expects milliseconds since January 1, 1970, 00:00:00 GMT. The time given in the test translates to 7th March in GMT but date in filter expression is an earlier one so the test fails. This PR fixes that.
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xiarixiaoyao commented on pull request #5166: [MINOR] Fix dates as per UTC in TestDataSkippingUtils
Posted by GitBox <gi...@apache.org>.
xiarixiaoyao commented on pull request #5166:
URL: https://github.com/apache/hudi/pull/5166#issuecomment-1081842021
@codope
maybe we can set System.setProperty("user.timezone", "America/New_York") to solve this problem
@alexeykudinkin What's your time zone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5166: [MINOR] Fix dates as per UTC in TestDataSkippingUtils
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5166:
URL: https://github.com/apache/hudi/pull/5166#issuecomment-1081637181
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "374d574564c6cf61f5d4c9b896cdec033437e504",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7502",
"triggerID" : "374d574564c6cf61f5d4c9b896cdec033437e504",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 374d574564c6cf61f5d4c9b896cdec033437e504 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7502)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5166: [MINOR] Fix dates as per UTC in TestDataSkippingUtils
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5166:
URL: https://github.com/apache/hudi/pull/5166#issuecomment-1082728111
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "374d574564c6cf61f5d4c9b896cdec033437e504",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7502",
"triggerID" : "374d574564c6cf61f5d4c9b896cdec033437e504",
"triggerType" : "PUSH"
}, {
"hash" : "3a56def704443d2c0af1b9911c5db8265e791993",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7549",
"triggerID" : "3a56def704443d2c0af1b9911c5db8265e791993",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 374d574564c6cf61f5d4c9b896cdec033437e504 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7502)
* 3a56def704443d2c0af1b9911c5db8265e791993 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7549)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5166: [MINOR] Fix dates as per UTC in TestDataSkippingUtils
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5166:
URL: https://github.com/apache/hudi/pull/5166#issuecomment-1083006413
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "374d574564c6cf61f5d4c9b896cdec033437e504",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7502",
"triggerID" : "374d574564c6cf61f5d4c9b896cdec033437e504",
"triggerType" : "PUSH"
}, {
"hash" : "3a56def704443d2c0af1b9911c5db8265e791993",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7549",
"triggerID" : "3a56def704443d2c0af1b9911c5db8265e791993",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3a56def704443d2c0af1b9911c5db8265e791993 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7549)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5166: [MINOR] Fix dates as per UTC in TestDataSkippingUtils
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5166:
URL: https://github.com/apache/hudi/pull/5166#issuecomment-1083117930
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "374d574564c6cf61f5d4c9b896cdec033437e504",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7502",
"triggerID" : "374d574564c6cf61f5d4c9b896cdec033437e504",
"triggerType" : "PUSH"
}, {
"hash" : "3a56def704443d2c0af1b9911c5db8265e791993",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7549",
"triggerID" : "3a56def704443d2c0af1b9911c5db8265e791993",
"triggerType" : "PUSH"
}, {
"hash" : "3a56def704443d2c0af1b9911c5db8265e791993",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7563",
"triggerID" : "1083117107",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 3a56def704443d2c0af1b9911c5db8265e791993 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7549) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7563)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5166: [MINOR] Fix dates as per UTC in TestDataSkippingUtils
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5166:
URL: https://github.com/apache/hudi/pull/5166#issuecomment-1083006413
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "374d574564c6cf61f5d4c9b896cdec033437e504",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7502",
"triggerID" : "374d574564c6cf61f5d4c9b896cdec033437e504",
"triggerType" : "PUSH"
}, {
"hash" : "3a56def704443d2c0af1b9911c5db8265e791993",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7549",
"triggerID" : "3a56def704443d2c0af1b9911c5db8265e791993",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3a56def704443d2c0af1b9911c5db8265e791993 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7549)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5166: [MINOR] Fix dates as per UTC in TestDataSkippingUtils
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5166:
URL: https://github.com/apache/hudi/pull/5166#issuecomment-1081637181
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "374d574564c6cf61f5d4c9b896cdec033437e504",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7502",
"triggerID" : "374d574564c6cf61f5d4c9b896cdec033437e504",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 374d574564c6cf61f5d4c9b896cdec033437e504 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7502)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5166: [MINOR] Fix dates as per UTC in TestDataSkippingUtils
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5166:
URL: https://github.com/apache/hudi/pull/5166#issuecomment-1081757548
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "374d574564c6cf61f5d4c9b896cdec033437e504",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7502",
"triggerID" : "374d574564c6cf61f5d4c9b896cdec033437e504",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 374d574564c6cf61f5d4c9b896cdec033437e504 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7502)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope merged pull request #5166: [MINOR] Fix dates as per UTC in TestDataSkippingUtils
Posted by GitBox <gi...@apache.org>.
codope merged pull request #5166:
URL: https://github.com/apache/hudi/pull/5166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5166: [MINOR] Fix dates as per UTC in TestDataSkippingUtils
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5166:
URL: https://github.com/apache/hudi/pull/5166#issuecomment-1083117930
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "374d574564c6cf61f5d4c9b896cdec033437e504",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7502",
"triggerID" : "374d574564c6cf61f5d4c9b896cdec033437e504",
"triggerType" : "PUSH"
}, {
"hash" : "3a56def704443d2c0af1b9911c5db8265e791993",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7549",
"triggerID" : "3a56def704443d2c0af1b9911c5db8265e791993",
"triggerType" : "PUSH"
}, {
"hash" : "3a56def704443d2c0af1b9911c5db8265e791993",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7563",
"triggerID" : "1083117107",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 3a56def704443d2c0af1b9911c5db8265e791993 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7549) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7563)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5166: [MINOR] Fix dates as per UTC in TestDataSkippingUtils
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5166:
URL: https://github.com/apache/hudi/pull/5166#issuecomment-1081633846
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "374d574564c6cf61f5d4c9b896cdec033437e504",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "374d574564c6cf61f5d4c9b896cdec033437e504",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 374d574564c6cf61f5d4c9b896cdec033437e504 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5166: [MINOR] Fix dates as per UTC in TestDataSkippingUtils
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5166:
URL: https://github.com/apache/hudi/pull/5166#issuecomment-1081757548
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "374d574564c6cf61f5d4c9b896cdec033437e504",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7502",
"triggerID" : "374d574564c6cf61f5d4c9b896cdec033437e504",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 374d574564c6cf61f5d4c9b896cdec033437e504 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7502)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on pull request #5166: [MINOR] Fix dates as per UTC in TestDataSkippingUtils
Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on pull request #5166:
URL: https://github.com/apache/hudi/pull/5166#issuecomment-1082253783
Sorry for the trouble folks, adding those tests i simply ignored the fact that these are in my local TZ.
Thanks for fixing this @codope
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5166: [MINOR] Fix dates as per UTC in TestDataSkippingUtils
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5166:
URL: https://github.com/apache/hudi/pull/5166#issuecomment-1081633846
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "374d574564c6cf61f5d4c9b896cdec033437e504",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "374d574564c6cf61f5d4c9b896cdec033437e504",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 374d574564c6cf61f5d4c9b896cdec033437e504 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5166: [MINOR] Fix dates as per UTC in TestDataSkippingUtils
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5166:
URL: https://github.com/apache/hudi/pull/5166#issuecomment-1082725338
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "374d574564c6cf61f5d4c9b896cdec033437e504",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7502",
"triggerID" : "374d574564c6cf61f5d4c9b896cdec033437e504",
"triggerType" : "PUSH"
}, {
"hash" : "3a56def704443d2c0af1b9911c5db8265e791993",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3a56def704443d2c0af1b9911c5db8265e791993",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 374d574564c6cf61f5d4c9b896cdec033437e504 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7502)
* 3a56def704443d2c0af1b9911c5db8265e791993 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xiarixiaoyao commented on pull request #5166: [MINOR] Fix dates as per UTC in TestDataSkippingUtils
Posted by GitBox <gi...@apache.org>.
xiarixiaoyao commented on pull request #5166:
URL: https://github.com/apache/hudi/pull/5166#issuecomment-1083117107
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5166: [MINOR] Fix dates as per UTC in TestDataSkippingUtils
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5166:
URL: https://github.com/apache/hudi/pull/5166#issuecomment-1082725338
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "374d574564c6cf61f5d4c9b896cdec033437e504",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7502",
"triggerID" : "374d574564c6cf61f5d4c9b896cdec033437e504",
"triggerType" : "PUSH"
}, {
"hash" : "3a56def704443d2c0af1b9911c5db8265e791993",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3a56def704443d2c0af1b9911c5db8265e791993",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 374d574564c6cf61f5d4c9b896cdec033437e504 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7502)
* 3a56def704443d2c0af1b9911c5db8265e791993 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5166: [MINOR] Fix dates as per UTC in TestDataSkippingUtils
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5166:
URL: https://github.com/apache/hudi/pull/5166#issuecomment-1082728111
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "374d574564c6cf61f5d4c9b896cdec033437e504",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7502",
"triggerID" : "374d574564c6cf61f5d4c9b896cdec033437e504",
"triggerType" : "PUSH"
}, {
"hash" : "3a56def704443d2c0af1b9911c5db8265e791993",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7549",
"triggerID" : "3a56def704443d2c0af1b9911c5db8265e791993",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 374d574564c6cf61f5d4c9b896cdec033437e504 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7502)
* 3a56def704443d2c0af1b9911c5db8265e791993 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7549)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5166: [MINOR] Fix dates as per UTC in TestDataSkippingUtils
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5166:
URL: https://github.com/apache/hudi/pull/5166#issuecomment-1083213767
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "374d574564c6cf61f5d4c9b896cdec033437e504",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7502",
"triggerID" : "374d574564c6cf61f5d4c9b896cdec033437e504",
"triggerType" : "PUSH"
}, {
"hash" : "3a56def704443d2c0af1b9911c5db8265e791993",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7549",
"triggerID" : "3a56def704443d2c0af1b9911c5db8265e791993",
"triggerType" : "PUSH"
}, {
"hash" : "3a56def704443d2c0af1b9911c5db8265e791993",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7563",
"triggerID" : "1083117107",
"triggerType" : "MANUAL"
}, {
"hash" : "3a56def704443d2c0af1b9911c5db8265e791993",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7549",
"triggerID" : "1083117107",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 3a56def704443d2c0af1b9911c5db8265e791993 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7563) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7549)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on a change in pull request #5166: [MINOR] Fix dates as per UTC in TestDataSkippingUtils
Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on a change in pull request #5166:
URL: https://github.com/apache/hudi/pull/5166#discussion_r837803667
##########
File path: hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/TestDataSkippingUtils.scala
##########
@@ -384,186 +384,187 @@ object TestDataSkippingUtils {
}
def testCompositeFilterExpressionsSource(): java.util.stream.Stream[Arguments] = {
Review comment:
Let's also make sure we fix TZ in the test:
Please add to the `testLookupFilterExpressions`
```
spark.sqlContext.setConf(SQLConf.SESSION_LOCAL_TIMEZONE.key, "UTC")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org