You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Deep Singh <de...@gmail.com> on 2020/10/06 02:05:07 UTC
Review Request 72932: ATLAS-3964: Fix for regression caused by
earlier patch
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72932/
-----------------------------------------------------------
Review request for atlas, keval bhatt, Madhan Neethiraj, and Sarath Subramanian.
Bugs: ATLAS-3964
https://issues.apache.org/jira/browse/ATLAS-3964
Repository: atlas
Description
-------
Regression was observed in counts of entities.
With earlier patch all sorts of numbers were parsed into string.
Only those numbers where information is being lost must be passed into a string.
Diffs
-----
dashboardv2/public/js/utils/Overrides.js 63770b5c3
dashboardv3/public/js/utils/Overrides.js 63770b5c3
Diff: https://reviews.apache.org/r/72932/diff/1/
Testing
-------
Testing was done on Atlas loaded with 3738 entities (2057 active and 1681 deleted)
Thanks,
Deep Singh
Re: Review Request 72932: ATLAS-3964: Fix for regression caused by
earlier patch
Posted by Deep Singh <de...@gmail.com>.
> On Oct. 6, 2020, 2:13 a.m., Ashutosh Mestry wrote:
> > LGTM. I will let Keval review it. Perhaps there is some JS where all these re-usable methods are kept. Right now there is duplication of code.
Its not duplication of code. There are two codebases for UI. DashboardV2 and DashboardV3. We need to commit at both the places as only one of it gets loaded at a time.
- Deep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72932/#review221994
-----------------------------------------------------------
On Oct. 6, 2020, 2:05 a.m., Deep Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72932/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2020, 2:05 a.m.)
>
>
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3964
> https://issues.apache.org/jira/browse/ATLAS-3964
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Regression was observed in counts of entities.
> With earlier patch all sorts of numbers were parsed into string.
> Only those numbers where information is being lost must be passed into a string.
>
>
> Diffs
> -----
>
> dashboardv2/public/js/utils/Overrides.js 63770b5c3
> dashboardv3/public/js/utils/Overrides.js 63770b5c3
>
>
> Diff: https://reviews.apache.org/r/72932/diff/1/
>
>
> Testing
> -------
>
> Testing was done on Atlas loaded with 3738 entities (2057 active and 1681 deleted)
>
>
> Thanks,
>
> Deep Singh
>
>
Re: Review Request 72932: ATLAS-3964: Fix for regression caused by
earlier patch
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72932/#review221994
-----------------------------------------------------------
LGTM. I will let Keval review it. Perhaps there is some JS where all these re-usable methods are kept. Right now there is duplication of code.
- Ashutosh Mestry
On Oct. 6, 2020, 2:05 a.m., Deep Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72932/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2020, 2:05 a.m.)
>
>
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3964
> https://issues.apache.org/jira/browse/ATLAS-3964
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Regression was observed in counts of entities.
> With earlier patch all sorts of numbers were parsed into string.
> Only those numbers where information is being lost must be passed into a string.
>
>
> Diffs
> -----
>
> dashboardv2/public/js/utils/Overrides.js 63770b5c3
> dashboardv3/public/js/utils/Overrides.js 63770b5c3
>
>
> Diff: https://reviews.apache.org/r/72932/diff/1/
>
>
> Testing
> -------
>
> Testing was done on Atlas loaded with 3738 entities (2057 active and 1681 deleted)
>
>
> Thanks,
>
> Deep Singh
>
>
Re: Review Request 72932: ATLAS-3964: Fix for regression caused by
earlier patch
Posted by keval bhatt <kb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72932/#review221997
-----------------------------------------------------------
Ship it!
Ship It!
- keval bhatt
On Oct. 6, 2020, 2:05 a.m., Deep Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72932/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2020, 2:05 a.m.)
>
>
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3964
> https://issues.apache.org/jira/browse/ATLAS-3964
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Regression was observed in counts of entities.
> With earlier patch all sorts of numbers were parsed into string.
> Only those numbers where information is being lost must be passed into a string.
>
>
> Diffs
> -----
>
> dashboardv2/public/js/utils/Overrides.js 63770b5c3
> dashboardv3/public/js/utils/Overrides.js 63770b5c3
>
>
> Diff: https://reviews.apache.org/r/72932/diff/1/
>
>
> Testing
> -------
>
> Testing was done on Atlas loaded with 3738 entities (2057 active and 1681 deleted)
>
>
> Thanks,
>
> Deep Singh
>
>