Re: [PATCH] close extern "C"

[Karl Fogel <kf...@newton.ch.collab.net>]

Applied, thanks Philip!

-K

Philip Martin <ph...@ntlworld.com> writes:
> Greg Stein <gs...@lyra.org> writes:
> 
> > Note that I believe many of our headers have ordering problems with the C++
> > namespace wrappers. I'm just taking this opportunity to point out the
> > "proper" behavior/coding :-)
> 
> Mentioning C++ prompted me to try:
> 
> $ find svn/subversion/include -type f -name \*.h | grep -v \\.svn | sed 's/.*/#include "&"'/ > z.cc
> g++ -Isvn/expat-lite -I/usr/local/apache/include -Isvn/subversion/include -Isvn/apr/include z.cc
> z.cc:50: parse error at end of input
> 
> Hence the following patch:
> 
> 
> 
> * subversion/include/svn_sorts.h: close extern "C"
> * subversion/include/svn_hash.h: close extern "C"
> 
> Index: subversion/include/svn_sorts.h
> ===================================================================
> --- subversion/include/.svn/text-base/svn_sorts.h	Sun Oct 28 14:11:44 2001
> +++ subversion/include/svn_sorts.h	Tue Oct 30 23:27:39 2001
> @@ -85,6 +85,9 @@
>                        apr_pool_t *pool);
>  #endif /* apr_hash_sorted_keys */
>  
> +#ifdef __cplusplus
> +}
> +#endif /* __cplusplus */
>  
>  #endif /* SVN_SORTS_H */
>  
> Index: subversion/include/svn_hash.h
> ===================================================================
> --- subversion/include/.svn/text-base/svn_hash.h	Sun Oct 28 14:11:43 2001
> +++ subversion/include/svn_hash.h	Tue Oct 30 23:29:20 2001
> @@ -86,6 +86,9 @@
>   */
>  void *svn_pack_bytestring (size_t len, const char *val, apr_pool_t *pool);
>  
> +#ifdef __cplusplus
> +}
> +#endif /* __cplusplus */
>  
>  #endif /* SVN_HASH_H */
>  
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org