[GitHub] [cloudstack] GutoVeronezi edited a comment on pull request #4699: Add new registers in guest_os

[GitBox <gi...@apache.org>]

GutoVeronezi edited a comment on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-890130499


   @DaanHoogland, you're right, we lost the focus.
   
   Getting back to the topic...
   
   The SQL in this PR would not hide any other solution, as it would insert new data, like we did many times before, and I do agree with a better structure for future works. At first, the implementation was a "simple" insert, however, by suggestion (here https://github.com/apache/cloudstack/pull/4699#issuecomment-780855187), I created a stored procedure, which could be reutilized. If it makes sense, we could get back to the first implementation, as the stored procedure may not be necessary in the future, with a better structured management.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org