You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/04/29 17:51:26 UTC

[GitHub] [tvm] zxybazh commented on pull request #7936: [Target][Legalization]Add Tir Level Legalization Function Registration And Update Intrinsic Lowering Pass

zxybazh commented on pull request #7936:
URL: https://github.com/apache/tvm/pull/7936#issuecomment-829465951


   IMHO, the intrinsic lowering pass logic is already in `src/tir` and the intrinsic lowering ruls are more target dependent so I think it's okay if we keep those rules in `src/target`. However, since it's pure tir level manipulation, I would be fine if we want to move all intrinsic lowering and legalization rules to `src/tir/intrin` and `src/tir/legalization`, and manage them together. Would like to see how others think about it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org