You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2023/01/11 21:38:07 UTC
[GitHub] [tinkerpop] Cole-Greer opened a new pull request, #1938: [TINKERPOP-2844] Adds tests for per-request-settings in GLV's
Cole-Greer opened a new pull request, #1938:
URL: https://github.com/apache/tinkerpop/pull/1938
https://issues.apache.org/jira/browse/TINKERPOP-2844
Creates a test where a driver sends a request to gremlin-socket-server with all per-request settings set. gremlin-socket-server extracts these arguments and returns them in a string to the driver.
I expanded the scope of the ticket a bit and added this test to Java, .net, and JS in addition to Python. Go is excluded from this commit as the test is failing and needs additional work. The go per request settings issue is being tracked by [TINKERPOP-2841](https://issues.apache.org/jira/browse/TINKERPOP-2841)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] vkagamlyk commented on a diff in pull request #1938: [TINKERPOP-2844] Adds tests for per-request-settings in GLV's
Posted by GitBox <gi...@apache.org>.
vkagamlyk commented on code in PR #1938:
URL: https://github.com/apache/tinkerpop/pull/1938#discussion_r1067484871
##########
gremlin-javascript/src/main/javascript/gremlin-javascript/test/integration/client-behavior-tests.js:
##########
@@ -64,5 +63,15 @@ describe('Client', function () {
await noUserAgentClient.close();
});
+ it('should send per request settings to server', async function () {
+ let resultSet = await client.submit('1', null, {
Review Comment:
better to use `const` to declare immutable variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] codecov-commenter commented on pull request #1938: [TINKERPOP-2844] Adds tests for per-request-settings in GLV's
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1938:
URL: https://github.com/apache/tinkerpop/pull/1938#issuecomment-1379535499
# [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1938?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1938](https://codecov.io/gh/apache/tinkerpop/pull/1938?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (54854ae) into [master](https://codecov.io/gh/apache/tinkerpop/commit/e4d3732ce69719f7f41bc411a5a2955b60858d6d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4d3732) will **decrease** coverage by `4.32%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 54854ae differs from pull request most recent head ac9fe1b. Consider uploading reports for the commit ac9fe1b to get more accurate results
```diff
@@ Coverage Diff @@
## master #1938 +/- ##
============================================
- Coverage 68.59% 64.27% -4.33%
============================================
Files 854 24 -830
Lines 41179 3728 -37451
Branches 5597 0 -5597
============================================
- Hits 28248 2396 -25852
+ Misses 10953 1166 -9787
+ Partials 1978 166 -1812
```
| [Impacted Files](https://codecov.io/gh/apache/tinkerpop/pull/1938?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...structure/io/binary/types/LocalTimeSerializer.java](https://codecov.io/gh/apache/tinkerpop/pull/1938?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvaW8vYmluYXJ5L3R5cGVzL0xvY2FsVGltZVNlcmlhbGl6ZXIuamF2YQ==) | | |
| [...ucture/io/graphson/GraphSONTypeSerializerV2d0.java](https://codecov.io/gh/apache/tinkerpop/pull/1938?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvaW8vZ3JhcGhzb24vR3JhcGhTT05UeXBlU2VyaWFsaXplclYyZDAuamF2YQ==) | | |
| [...pop/gremlin/process/traversal/step/Generating.java](https://codecov.io/gh/apache/tinkerpop/pull/1938?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdGVwL0dlbmVyYXRpbmcuamF2YQ==) | | |
| [...in/tinkergraph/structure/TinkerGraphVariables.java](https://codecov.io/gh/apache/tinkerpop/pull/1938?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGlua2VyZ3JhcGgtZ3JlbWxpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdGlua2VycG9wL2dyZW1saW4vdGlua2VyZ3JhcGgvc3RydWN0dXJlL1RpbmtlckdyYXBoVmFyaWFibGVzLmphdmE=) | | |
| [...mlin/process/traversal/step/util/AbstractStep.java](https://codecov.io/gh/apache/tinkerpop/pull/1938?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdGVwL3V0aWwvQWJzdHJhY3RTdGVwLmphdmE=) | | |
| [...traversal/traverser/NL\_O\_OB\_S\_SE\_SL\_Traverser.java](https://codecov.io/gh/apache/tinkerpop/pull/1938?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC90cmF2ZXJzZXIvTkxfT19PQl9TX1NFX1NMX1RyYXZlcnNlci5qYXZh) | | |
| [...lin/structure/io/graphson/GraphSONXModuleV2d0.java](https://codecov.io/gh/apache/tinkerpop/pull/1938?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvaW8vZ3JhcGhzb24vR3JhcGhTT05YTW9kdWxlVjJkMC5qYXZh) | | |
| [...aversal/strategy/finalization/ProfileStrategy.java](https://codecov.io/gh/apache/tinkerpop/pull/1938?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdHJhdGVneS9maW5hbGl6YXRpb24vUHJvZmlsZVN0cmF0ZWd5LmphdmE=) | | |
| [...vy/jsr223/ast/VarAsBindingASTTransformation.groovy](https://codecov.io/gh/apache/tinkerpop/pull/1938?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1ncm9vdnkvc3JjL21haW4vZ3Jvb3Z5L29yZy9hcGFjaGUvdGlua2VycG9wL2dyZW1saW4vZ3Jvb3Z5L2pzcjIyMy9hc3QvVmFyQXNCaW5kaW5nQVNUVHJhbnNmb3JtYXRpb24uZ3Jvb3Z5) | | |
| [...op/gremlin/tinkergraph/structure/TinkerHelper.java](https://codecov.io/gh/apache/tinkerpop/pull/1938?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGlua2VyZ3JhcGgtZ3JlbWxpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdGlua2VycG9wL2dyZW1saW4vdGlua2VyZ3JhcGgvc3RydWN0dXJlL1RpbmtlckhlbHBlci5qYXZh) | | |
| ... and [820 more](https://codecov.io/gh/apache/tinkerpop/pull/1938?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] vkagamlyk commented on pull request #1938: [TINKERPOP-2844] Adds tests for per-request-settings in GLV's
Posted by GitBox <gi...@apache.org>.
vkagamlyk commented on PR #1938:
URL: https://github.com/apache/tinkerpop/pull/1938#issuecomment-1379660406
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] xiazcy commented on pull request #1938: [TINKERPOP-2844] Adds tests for per-request-settings in GLV's
Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy commented on PR #1938:
URL: https://github.com/apache/tinkerpop/pull/1938#issuecomment-1414551204
Thanks! Merging now given lazy consensus.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] xiazcy merged pull request #1938: [TINKERPOP-2844] Adds tests for per-request-settings in GLV's
Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy merged PR #1938:
URL: https://github.com/apache/tinkerpop/pull/1938
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org