You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "hxmhlt (GitHub)" <gi...@apache.org> on 2019/09/10 13:02:26 UTC
[GitHub] [dubbo-go] hxmhlt opened pull request #198: Add:retries
mergeUrl
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
Add:retries mergeUrl
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
[ Full content available at: https://github.com/apache/dubbo-go/pull/198 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] hxmhlt closed pull request #198: Add:retries
mergeUrl
Posted by "hxmhlt (GitHub)" <gi...@apache.org>.
[ pull request closed by hxmhlt ]
[ Full content available at: https://github.com/apache/dubbo-go/pull/198 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #198: Add:retries
mergeUrl
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/198?src=pr&el=h1) Report
> Merging [#198](https://codecov.io/gh/apache/dubbo-go/pull/198?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/359bdab8e26f71b54158d21a18ad8313790785c0?src=pr&el=desc) will **increase** coverage by `0.14%`.
> The diff coverage is `90.9%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/198?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #198 +/- ##
===========================================
+ Coverage 66.71% 66.85% +0.14%
===========================================
Files 94 94
Lines 5870 5817 -53
===========================================
- Hits 3916 3889 -27
+ Misses 1545 1531 -14
+ Partials 409 397 -12
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/198?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/198/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `74.89% <90.9%> (+4.55%)` | :arrow_up: |
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/198/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `18.33% <0%> (-81.67%)` | :arrow_down: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/198/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `50% <0%> (-4.17%)` | :arrow_down: |
| [protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/198/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==) | `69.23% <0%> (-2.57%)` | :arrow_down: |
| [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/198/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `75% <0%> (-1.54%)` | :arrow_down: |
| [protocol/dubbo/dubbo\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/198/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9fcHJvdG9jb2wuZ28=) | `95.55% <0%> (ø)` | :arrow_up: |
| [protocol/dubbo/dubbo\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/198/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9faW52b2tlci5nbw==) | `82.92% <0%> (+0.87%)` | :arrow_up: |
| [filter/impl/echo\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/198/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvZWNob19maWx0ZXIuZ28=) | `85.71% <0%> (+1.09%)` | :arrow_up: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/198/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `70.94% <0%> (+2.56%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/dubbo-go/pull/198/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/198?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/198?src=pr&el=footer). Last update [359bdab...8f9295b](https://codecov.io/gh/apache/dubbo-go/pull/198?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/198 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org