You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "sivabalan narayanan (Jira)" <ji...@apache.org> on 2021/11/15 14:39:00 UTC

[jira] [Commented] (HUDI-2005) Audit and remove references of fs.listStatus() and fs.getFileStatus() or fs.exists()

    [ https://issues.apache.org/jira/browse/HUDI-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17443859#comment-17443859 ] 

sivabalan narayanan commented on HUDI-2005:
-------------------------------------------

Most of the fs calls above are from actual writer classes which deals with uncommittted data and hence we can't route them to BaseTableMetadata. 

 

There are only two calls that needs to be fixed:

1. FSUtilscreatePathIfNotExists(). this is invoked from AbstractTableFileSystemView#ensurePartitionLoadedCorrectly
{code:java}
public static void createPathIfNotExists(FileSystem fs, Path partitionPath) throws IOException {
  if (!fs.exists(partitionPath)) {
    fs.mkdirs(partitionPath);
  }
}{code}
2. HoodieLogFileReader fetches log file position using 
{code:java}
if (this.reverseReader) {
  this.reverseLogFilePosition = this.lastReverseLogFilePosition = fs.getFileStatus(logFile.getPath()).getLen();
}{code}

> Audit and remove references of fs.listStatus() and fs.getFileStatus() or fs.exists()
> ------------------------------------------------------------------------------------
>
>                 Key: HUDI-2005
>                 URL: https://issues.apache.org/jira/browse/HUDI-2005
>             Project: Apache Hudi
>          Issue Type: Sub-task
>            Reporter: Nishith Agarwal
>            Assignee: sivabalan narayanan
>            Priority: Blocker
>              Labels: oct18_2021, pull-request-available
>             Fix For: 0.10.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)