You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/02/01 15:13:39 UTC

[GitHub] [hbase] virajjasani commented on a change in pull request #754: HBASE-22978 : Online slow response log

virajjasani commented on a change in pull request #754: HBASE-22978 : Online slow response log
URL: https://github.com/apache/hbase/pull/754#discussion_r371620037
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
 ##########
 @@ -215,6 +224,17 @@
    */
   private RSRpcServices rsRpcServices;
 
+
+  /**
+   * Use to add online slowlog responses
+   */
+  private OnlineSlowLogProvider onlineSlowLogProvider;
 
 Review comment:
   If we make it final, we add up more constructor arg which is again some pain, so IMHO better have setter method and let it be non-final please? :(

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services