You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2023/12/13 08:09:46 UTC
[PR] Improve GPG instructions in the contribution guide [pulsar-site]
lhotari opened a new pull request, #750:
URL: https://github.com/apache/pulsar-site/pull/750
The GPG instructions are unclear and some instructions (such as MacOS keychain integration) are missing.
This PR improves the instructions.
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `./preview.sh` at root path) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve GPG instructions in the contribution guide [pulsar-site]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #750:
URL: https://github.com/apache/pulsar-site/pull/750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve GPG instructions in the contribution guide [pulsar-site]
Posted by "onobc (via GitHub)" <gi...@apache.org>.
onobc commented on code in PR #750:
URL: https://github.com/apache/pulsar-site/pull/750#discussion_r1425480471
##########
contribute/create-gpg-keys.md:
##########
@@ -78,19 +92,29 @@ Change (N)ame, (C)omment, (E)mail or (O)kay/(Q)uit? O
<Enter passphrase>
```
-:::note
+## Upload the key to a public key server
-New **RSA** keys generated should be at least **4096** bits.
+Use the key id to publish it to several public key servers:
-:::
+```shell
+# find out your key id
+APACHEID=your_asf_id
+KEY_ID=$(gpg --list-keys --with-colons $APACHEID@apache.org | egrep "^pub" | awk -F: '{print $5}')
+echo "key id: $KEY_ID"
+# send the public key to multiple servers
+gpg --send-key $KEY_ID
Review Comment:
These sends fail w/ `"no route to host"`. Instead the documentation says to use
```
gpg --send-key --keyserver=hkp://pool.sks-keyservers.net $KEY_ID
```
Although that resulted in a "server indicated a failure" response. However, it looks like the key was added as I got an email indicating so. I think we can add the following verbiage to the end of this step.
<NEW_CONTENT>
If the `send-key` steps fail with `no route to host` then instead try the following command:
```
gpg --send-key --keyserver=hkp://ipv4.pool.sks-keyservers.net $KEY_ID
```
:::note The above command may return a `"gpg: keyserver send failed: Server indicated a failure"` response but most likely the key was added. Check your email for a message from keyserver@keys.openpgp.org with subject `"Your key upload on keys.openpgp.org"` and verify the key in the email body matches your submitted key. If you do not receive an email, reach out to another member for help.
</NEW_CONTENT>
Wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve GPG instructions in the contribution guide [pulsar-site]
Posted by "onobc (via GitHub)" <gi...@apache.org>.
onobc commented on code in PR #750:
URL: https://github.com/apache/pulsar-site/pull/750#discussion_r1425675146
##########
contribute/create-gpg-keys.md:
##########
@@ -78,19 +92,29 @@ Change (N)ame, (C)omment, (E)mail or (O)kay/(Q)uit? O
<Enter passphrase>
```
-:::note
+## Upload the key to a public key server
-New **RSA** keys generated should be at least **4096** bits.
+Use the key id to publish it to several public key servers:
-:::
+```shell
+# find out your key id
+APACHEID=your_asf_id
+KEY_ID=$(gpg --list-keys --with-colons $APACHEID@apache.org | egrep "^pub" | awk -F: '{print $5}')
+echo "key id: $KEY_ID"
+# send the public key to multiple servers
+gpg --send-key $KEY_ID
Review Comment:
I just saw your commit. If that works then this is sufficient. Thanks for the update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve GPG instructions in the contribution guide [pulsar-site]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #750:
URL: https://github.com/apache/pulsar-site/pull/750#discussion_r1425664983
##########
contribute/create-gpg-keys.md:
##########
@@ -78,19 +92,29 @@ Change (N)ame, (C)omment, (E)mail or (O)kay/(Q)uit? O
<Enter passphrase>
```
-:::note
+## Upload the key to a public key server
-New **RSA** keys generated should be at least **4096** bits.
+Use the key id to publish it to several public key servers:
-:::
+```shell
+# find out your key id
+APACHEID=your_asf_id
+KEY_ID=$(gpg --list-keys --with-colons $APACHEID@apache.org | egrep "^pub" | awk -F: '{print $5}')
+echo "key id: $KEY_ID"
+# send the public key to multiple servers
+gpg --send-key $KEY_ID
Review Comment:
Also at https://github.com/asdf-vm/asdf-nodejs/issues/192#issuecomment-797448073
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve GPG instructions in the contribution guide [pulsar-site]
Posted by "onobc (via GitHub)" <gi...@apache.org>.
onobc commented on code in PR #750:
URL: https://github.com/apache/pulsar-site/pull/750#discussion_r1425673902
##########
contribute/create-gpg-keys.md:
##########
@@ -78,19 +92,29 @@ Change (N)ame, (C)omment, (E)mail or (O)kay/(Q)uit? O
<Enter passphrase>
```
-:::note
+## Upload the key to a public key server
-New **RSA** keys generated should be at least **4096** bits.
+Use the key id to publish it to several public key servers:
-:::
+```shell
+# find out your key id
+APACHEID=your_asf_id
+KEY_ID=$(gpg --list-keys --with-colons $APACHEID@apache.org | egrep "^pub" | awk -F: '{print $5}')
+echo "key id: $KEY_ID"
+# send the public key to multiple servers
+gpg --send-key $KEY_ID
Review Comment:
What is concerning is that it seems that some of the servers are going away soon? Is there some official docs that we could instead point to that says "If you have issues please see the offiical docs..."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve GPG instructions in the contribution guide [pulsar-site]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #750:
URL: https://github.com/apache/pulsar-site/pull/750#discussion_r1425661114
##########
contribute/create-gpg-keys.md:
##########
@@ -78,19 +92,29 @@ Change (N)ame, (C)omment, (E)mail or (O)kay/(Q)uit? O
<Enter passphrase>
```
-:::note
+## Upload the key to a public key server
-New **RSA** keys generated should be at least **4096** bits.
+Use the key id to publish it to several public key servers:
-:::
+```shell
+# find out your key id
+APACHEID=your_asf_id
+KEY_ID=$(gpg --list-keys --with-colons $APACHEID@apache.org | egrep "^pub" | awk -F: '{print $5}')
+echo "key id: $KEY_ID"
+# send the public key to multiple servers
+gpg --send-key $KEY_ID
Review Comment:
The `ipv4.pool.sks-keyservers.net` address no longer exists. Doing `dig ipv4.pool.sks-keyservers.net` or `nslookup ipv4.pool.sks-keyservers.net` will fail.
I think that the problem could actually be related to DNS.
I found this resolution in StackOverflow:
https://stackoverflow.com/a/67259857
I think it might be the proper resolution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org