You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@phoenix.apache.org by "Samarth Jain (JIRA)" <ji...@apache.org> on 2016/01/26 18:04:39 UTC

[jira] [Commented] (PHOENIX-2630) Ensure commit fails if mutable secondary index write fails

    [ https://issues.apache.org/jira/browse/PHOENIX-2630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117565#comment-15117565 ] 

Samarth Jain commented on PHOENIX-2630:
---------------------------------------

+1, looks good.

> Ensure commit fails if mutable secondary index write fails
> ----------------------------------------------------------
>
>                 Key: PHOENIX-2630
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2630
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Priority: Blocker
>         Attachments: PHOENIX-2630.patch
>
>
> See MutableIndexFailureIT. This commit removed the fail() after the commit() which is wrong: https://github.com/apache/phoenix/commit/3d69fa21123d182577a58bbc517d40ea9dc5a2cd#diff-de5444255a9f79a58ad86932fd6a2afd
> We need to add it back and confirm that the test still passes. If the index write fails, the commit needs to throw - otherwise the client won't know there was a failure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)