You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "MaxGekk (via GitHub)" <gi...@apache.org> on 2025/07/01 16:17:50 UTC
[PR] [WIP][SQL][TESTS] Disable stable column aliases in tests that it is assumed [spark]
MaxGekk opened a new pull request, #51337:
URL: https://github.com/apache/spark/pull/51337
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP][SQL][TESTS] Disable stable column aliases in tests if assumed [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #51337:
URL: https://github.com/apache/spark/pull/51337#discussion_r2182181655
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -5580,7 +5580,7 @@ object SQLConf {
"and form them via pretty SQL print.")
.version("3.5.0")
.booleanConf
- .createWithDefault(false)
+ .createWithDefault(true)
Review Comment:
I think we should handle test failures carefully and figure out if there is any bug in this feature, instead of blindly turning off the config.
This will take a long time and we should invite the community to work on it together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP][SQL][TESTS] Disable stable column aliases in tests if assumed [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #51337:
URL: https://github.com/apache/spark/pull/51337#discussion_r2179384228
##########
connector/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala:
##########
@@ -1762,7 +1762,9 @@ abstract class AvroSuite
}
test("error handling for unsupported Interval data types") {
- withSQLConf(SQLConf.LEGACY_INTERVAL_ENABLED.key -> "true") {
+ withSQLConf(
+ SQLConf.STABLE_DERIVED_COLUMN_ALIAS_ENABLED.key -> "false",
Review Comment:
Yep, this could be another way, but this require much more work. I will try my best, and change some test in this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP][SQL][TESTS] Disable stable column aliases in tests if assumed [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #51337:
URL: https://github.com/apache/spark/pull/51337#discussion_r2179392451
##########
connector/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala:
##########
@@ -1762,7 +1762,9 @@ abstract class AvroSuite
}
test("error handling for unsupported Interval data types") {
- withSQLConf(SQLConf.LEGACY_INTERVAL_ENABLED.key -> "true") {
+ withSQLConf(
+ SQLConf.STABLE_DERIVED_COLUMN_ALIAS_ENABLED.key -> "false",
Review Comment:
I think it's better to not randomly switch this conf here and there. We just need to publish a good habit for writing tests: alias the expressions when necessary to have stable alias.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP][SQL][TESTS] Disable stable column aliases in tests if assumed [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #51337:
URL: https://github.com/apache/spark/pull/51337#discussion_r2179381143
##########
connector/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala:
##########
@@ -1762,7 +1762,9 @@ abstract class AvroSuite
}
test("error handling for unsupported Interval data types") {
- withSQLConf(SQLConf.LEGACY_INTERVAL_ENABLED.key -> "true") {
+ withSQLConf(
+ SQLConf.STABLE_DERIVED_COLUMN_ALIAS_ENABLED.key -> "false",
Review Comment:
can we change the test query to add explicit alias?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP][SQL][TESTS] Disable stable column aliases in tests if assumed [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #51337:
URL: https://github.com/apache/spark/pull/51337#discussion_r2182241715
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -5580,7 +5580,7 @@ object SQLConf {
"and form them via pretty SQL print.")
.version("3.5.0")
.booleanConf
- .createWithDefault(false)
+ .createWithDefault(true)
Review Comment:
I switched the config only to detect the tests that makes some assumption about column aliases algorithm. Not going to merge it.
> we should handle test failures carefully and figure out if there is any bug in this feature
I agree. We should.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP][SQL][TESTS] Disable stable column aliases in tests if assumed [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #51337:
URL: https://github.com/apache/spark/pull/51337#discussion_r2179384228
##########
connector/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala:
##########
@@ -1762,7 +1762,9 @@ abstract class AvroSuite
}
test("error handling for unsupported Interval data types") {
- withSQLConf(SQLConf.LEGACY_INTERVAL_ENABLED.key -> "true") {
+ withSQLConf(
+ SQLConf.STABLE_DERIVED_COLUMN_ALIAS_ENABLED.key -> "false",
Review Comment:
Yep, this could be another way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP][SQL][TESTS] Disable stable column aliases in tests if assumed [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #51337:
URL: https://github.com/apache/spark/pull/51337#discussion_r2182241715
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -5580,7 +5580,7 @@ object SQLConf {
"and form them via pretty SQL print.")
.version("3.5.0")
.booleanConf
- .createWithDefault(false)
+ .createWithDefault(true)
Review Comment:
I switched the config only to detect the tests that make some assumption about column aliases algorithm. Not going to merge it.
> we should handle test failures carefully and figure out if there is any bug in this feature
I agree. We should.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP][SQL][TESTS] Disable stable column aliases in tests if assumed [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #51337:
URL: https://github.com/apache/spark/pull/51337#issuecomment-3393767168
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP][SQL][TESTS] Disable stable column aliases in tests if assumed [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #51337:
URL: https://github.com/apache/spark/pull/51337#discussion_r2179430018
##########
connector/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala:
##########
@@ -1762,7 +1762,9 @@ abstract class AvroSuite
}
test("error handling for unsupported Interval data types") {
- withSQLConf(SQLConf.LEGACY_INTERVAL_ENABLED.key -> "true") {
+ withSQLConf(
+ SQLConf.STABLE_DERIVED_COLUMN_ALIAS_ENABLED.key -> "false",
Review Comment:
> I think it's better to randomly switch this conf here and there.
It is good idea, but before implementing this we should make sure that existing tests are reliable to such behaviour otherwise we will destabilize the existing CI.
> We just need to publish a good habit for writing tests
Habits is nice, and I believe if a test writer assumes some naming convention, this assumption should be explicit via a config set otherwise he/she should assign an alias. How about to put this statement to the coding style?
> alias the expressions when necessary to have stable alias.
I will do when it is obvious, but some tests are depend `SQLConf.STABLE_DERIVED_COLUMN_ALIAS_ENABLED` for unknown reasons at least for me (I cannot say why without investigation). For instance, the simple case where names should be the same in plan and in the query independently from the config:
```scala
test("SPARK-42552: select and union without parentheses") {
val plan = Distinct(OneRowRelation().select(Literal(1))
.union(OneRowRelation().select(Literal(1))))
assertEqual("select 1 union select 1", plan)
}
```
fails with:
```
== FAIL: Plans do not match ===
'Distinct 'Distinct
+- 'Union false, false +- 'Union false, false
:- 'Project [unresolvedalias(1)] :- 'Project [unresolvedalias(1)]
: +- OneRowRelation : +- OneRowRelation
+- 'Project [unresolvedalias(1)] +- 'Project [unresolvedalias(1)]
+- OneRowRelation +- OneRowRelation
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP][SQL][TESTS] Disable stable column aliases in tests if assumed [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #51337:
URL: https://github.com/apache/spark/pull/51337#discussion_r2182178942
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -5580,7 +5580,7 @@ object SQLConf {
"and form them via pretty SQL print.")
.version("3.5.0")
.booleanConf
- .createWithDefault(false)
+ .createWithDefault(true)
Review Comment:
We should have done it earlier to make sure this feature works well by passing all tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP][SQL][TESTS] Disable stable column aliases in tests if assumed [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #51337:
URL: https://github.com/apache/spark/pull/51337#discussion_r2179392451
##########
connector/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala:
##########
@@ -1762,7 +1762,9 @@ abstract class AvroSuite
}
test("error handling for unsupported Interval data types") {
- withSQLConf(SQLConf.LEGACY_INTERVAL_ENABLED.key -> "true") {
+ withSQLConf(
+ SQLConf.STABLE_DERIVED_COLUMN_ALIAS_ENABLED.key -> "false",
Review Comment:
I think it's better to randomly switch this conf here and there. We just need to publish a good habit for writing tests: alias the expressions when necessary to have stable alias.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP][SQL][TESTS] Disable stable column aliases in tests if assumed [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #51337: [WIP][SQL][TESTS] Disable stable column aliases in tests if assumed
URL: https://github.com/apache/spark/pull/51337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org