You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "zhengchenyu (via GitHub)" <gi...@apache.org> on 2024/07/31 07:22:33 UTC
[PR] [#1987] fix(tez): Application may get stuck when exception occurs. [incubator-uniffle]
zhengchenyu opened a new pull request, #1992:
URL: https://github.com/apache/incubator-uniffle/pull/1992
### What changes were proposed in this pull request?
In fact, we use allEventsReceived to determine whether all upstream tasks are completed, but allEventsReceived may be abnormal due to multiple events occurring in multiple attempts for the same task. So we need to count the number of tasks, do not count the duplicate task attempts.
### Why are the changes needed?
Fix: #1987
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
test in cluster
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1987] fix(tez): Application may get stuck when exception occurs. [incubator-uniffle]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1992:
URL: https://github.com/apache/incubator-uniffle/pull/1992#issuecomment-2260117541
## Test Results
2 747 files ±0 2 747 suites ±0 5h 40m 58s :stopwatch: -1s
979 tests ±0 969 :white_check_mark: - 7 1 :zzz: ±0 0 :x: ±0 9 :fire: + 7
12 294 runs ±0 12 261 :white_check_mark: - 16 15 :zzz: ±0 0 :x: ±0 18 :fire: +16
For more details on these errors, see [this check](https://github.com/apache/incubator-uniffle/runs/28150647938).
Results for commit f1a7e502. ± Comparison against base commit be6afb92.
[test-results]:data:application/gzip;base64,H4sIAOAIqmYC/03OTQ7CIBCG4as0rF0AAiNexuAACbE/hsLKeHcHU0iX3wO84cNimsPO7pMEBZeJ7TWV8/Y1u5K2tQlX+kZE56XdsGD7euwVsZE50Su9icSA6NJMwAeEnLfcXpHkuramkNKqY/YomRHDjqrucKr+d4+K9lXcliUVWiwKB0FzaZyCqAGjuSI38LTCSlTBe4fSK9Ds+wPvqm7wEwEAAA==
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1987] fix(tez): Application may get stuck when exception occurs. [incubator-uniffle]
Posted by "zhengchenyu (via GitHub)" <gi...@apache.org>.
zhengchenyu commented on PR #1992:
URL: https://github.com/apache/incubator-uniffle/pull/1992#issuecomment-2264390845
> Could you add a ut for this?
The bug is low probability event. So it is not easy to add ut.
I test in real cluster and add some random throw exception In special location tez code which is described in #1987, then we can reproduce the bug in high probability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1987] fix(tez): Application may get stuck when exception occurs. [incubator-uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #1992:
URL: https://github.com/apache/incubator-uniffle/pull/1992#issuecomment-2260351916
Could you add a ut for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1987] fix(tez): Application may get stuck when exception occurs. [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston merged PR #1992:
URL: https://github.com/apache/incubator-uniffle/pull/1992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org