You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by ggevay <gi...@git.apache.org> on 2015/05/31 13:33:19 UTC
[GitHub] flink pull request: [FLINK-2121] Fix the summation in FileInputFor...
GitHub user ggevay opened a pull request:
https://github.com/apache/flink/pull/752
[FLINK-2121] Fix the summation in FileInputFormat.addFilesInDir
Removed the length parameter, and made the length calculation start from 0 instead.
I also added a second inner dir to the test, so now it catches this problem with any directory listing order.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ggevay/flink dirSizeFix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/752.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #752
----
commit 7fc86ce10ddc640126c7da8265403a815a30c2d2
Author: Gabor Gevay <gg...@gmail.com>
Date: 2015-05-31T11:27:15Z
[FLINK-2121] Fix the recursive summation in FileInputFormat.addFilesInDir
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2121] Fix the summation in FileInputFor...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/752#issuecomment-107498384
+1, should go into the release candidate.
Will merge this now...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2121] Fix the summation in FileInputFor...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/752#issuecomment-107419256
LGTM. Thanks for spotting this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2121] Fix the summation in FileInputFor...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/752
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---