You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@streams.apache.org by steveblackmon <gi...@git.apache.org> on 2016/11/05 20:24:33 UTC
[GitHub] incubator-streams pull request #324: STREAMS-443 streams-project
GitHub user steveblackmon opened a pull request:
https://github.com/apache/incubator-streams/pull/324
STREAMS-443 streams-project
use org.apache.streams.plugins:streams-plugin-pojo instead of org.jsonschema2pojo
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/steveblackmon/incubator-streams STREAMS-443
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-streams/pull/324.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #324
----
commit 7269dffd7eb8a269b60d816f2fc4e157ae013bb5
Author: Steve Blackmon @steveblackmon <sb...@apache.org>
Date: 2016-11-05T19:52:23Z
STREAMS-443: remove duplicate json schemas from streams-pojo
remove now duplicated json schemas from streams-pojo
commit 3c8254b7ec8277ced0b27b0ede361578bfbfaefd
Author: Steve Blackmon @steveblackmon <sb...@apache.org>
Date: 2016-11-05T19:52:47Z
STREAMS-443: also remove unused AS 1.0 XML schemas
commit f29e4c1d22c9dedb66ee448de4a3fc8dad9ee985
Author: Steve Blackmon @steveblackmon <sb...@apache.org>
Date: 2016-11-05T19:54:24Z
remove full URL from schema id
they are unnecessary and complicate testing SchemaStore and code gen plugins
commit f61b768bd468a13b7b32a318a1995c116ae7da52
Author: Steve Blackmon @steveblackmon <sb...@apache.org>
Date: 2016-11-05T19:55:51Z
STREAMS-443: configure underlying plugin
commit 09bfe75feefe4dd966357270e2dec2c233fc3437
Author: Steve Blackmon @steveblackmon <sb...@apache.org>
Date: 2016-11-05T20:00:07Z
STREAMS-443: confirm test data matches official jsonschemas
commit 77d4990ec098226f15d73b1bc5018f7808265346
Author: Steve Blackmon @steveblackmon <sb...@apache.org>
Date: 2016-11-05T20:00:25Z
STREAMS-443: streams-plugin-pojo working as expected
commit dc109b8d7432e406c288fc95228915153453453e
Author: Steve Blackmon @steveblackmon <sb...@apache.org>
Date: 2016-11-05T20:01:57Z
STREAMS-443: changes to project poms and json schemas
commit 137cbef42caeb49ddfbb006dce5089e203fecf4a
Author: Steve Blackmon @steveblackmon <sb...@apache.org>
Date: 2016-11-05T20:09:34Z
STREAMS-443: use org.apache.streams.plugins:streams-plugin-pojo instead of org.jsonschema2pojo
Adapt to loss of Actor object using new plugin
Actor should not really be a distinct class from ActivityObject, because it doesn\u2019t have any differentiated fields or validation rules.
A few tests needed a bit more attention - all still pass and apply the original material criteria.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams issue #324: STREAMS-443 streams-project
Posted by jfrazee <gi...@git.apache.org>.
Github user jfrazee commented on the issue:
https://github.com/apache/incubator-streams/pull/324
On an initial read through the changes it LGTM. Still need to verify the behavior and think about how it all fits together, but none of the code/pom/schema changes screamed of problems.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams issue #324: STREAMS-443 streams-project
Posted by steveblackmon <gi...@git.apache.org>.
Github user steveblackmon commented on the issue:
https://github.com/apache/incubator-streams/pull/324
taking this as +1 and beginning merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams issue #324: STREAMS-443 streams-project
Posted by steveblackmon <gi...@git.apache.org>.
Github user steveblackmon commented on the issue:
https://github.com/apache/incubator-streams/pull/324
merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request #324: STREAMS-443 streams-project
Posted by steveblackmon <gi...@git.apache.org>.
Github user steveblackmon closed the pull request at:
https://github.com/apache/incubator-streams/pull/324
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams issue #324: STREAMS-443 streams-project
Posted by steveblackmon <gi...@git.apache.org>.
Github user steveblackmon commented on the issue:
https://github.com/apache/incubator-streams/pull/324
merged in 4f100f3a2e97ddc512a9d745b999625602ad274e
Squashed commit of STREAMS-443: use org.apache.streams.plugins:streams-plugin-pojo instead of org.jsonschema2pojo
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---