You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2016/02/12 20:56:56 UTC
Review Request 43538: Add checks and alerts when clusterconfigmapping
has multiple selected entries for a config type
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43538/
-----------------------------------------------------------
Review request for Ambari, Jayush Luniya and Myroslav Papirkovskyy.
Bugs: AMBARI-15034
https://issues.apache.org/jira/browse/AMBARI-15034
Repository: ambari
Description
-------
In clusterconfigmapping table we shouldn't have more than one entries for a config_type with selected=1
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDatabaseHelper.java a078c8a
Diff: https://reviews.apache.org/r/43538/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 43538: Add checks and alerts when
clusterconfigmapping has multiple selected entries for a config type
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43538/#review119076
-----------------------------------------------------------
Jayush, there is no reason to take in account config groups when checking selected configs from clusterconfgimapping. Looks like for config groups we have separate logic. Myroslav knows more about that, i've talked to him and he approved this solution.
- Vitalyi Brodetskyi
On Лют. 12, 2016, 7:56 після полудня, Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43538/
> -----------------------------------------------------------
>
> (Updated Лют. 12, 2016, 7:56 після полудня)
>
>
> Review request for Ambari, Jayush Luniya and Myroslav Papirkovskyy.
>
>
> Bugs: AMBARI-15034
> https://issues.apache.org/jira/browse/AMBARI-15034
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In clusterconfigmapping table we shouldn't have more than one entries for a config_type with selected=1
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDatabaseHelper.java a078c8a
>
> Diff: https://reviews.apache.org/r/43538/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 43538: Add checks and alerts when
clusterconfigmapping has multiple selected entries for a config type
Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43538/#review119078
-----------------------------------------------------------
Ship it!
This approach should be extended to cover service config versions as well. They are local to cluster also.
As far as this will be covered in another issue, I'm ok with this one.
- Myroslav Papirkovskyy
On Лют. 12, 2016, 10 після полудня, Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43538/
> -----------------------------------------------------------
>
> (Updated Лют. 12, 2016, 10 після полудня)
>
>
> Review request for Ambari, Jayush Luniya and Myroslav Papirkovskyy.
>
>
> Bugs: AMBARI-15034
> https://issues.apache.org/jira/browse/AMBARI-15034
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In clusterconfigmapping table we shouldn't have more than one entries for a config_type with selected=1
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDatabaseHelper.java a078c8a
> ambari-server/src/test/java/org/apache/ambari/server/checks/CheckDatabaseHelperTest.java e329ab7
>
> Diff: https://reviews.apache.org/r/43538/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 43538: Add checks and alerts when
clusterconfigmapping has multiple selected entries for a config type
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43538/
-----------------------------------------------------------
(Updated Лют. 12, 2016, 8 після полудня)
Review request for Ambari, Jayush Luniya and Myroslav Papirkovskyy.
Bugs: AMBARI-15034
https://issues.apache.org/jira/browse/AMBARI-15034
Repository: ambari
Description
-------
In clusterconfigmapping table we shouldn't have more than one entries for a config_type with selected=1
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDatabaseHelper.java a078c8a
ambari-server/src/test/java/org/apache/ambari/server/checks/CheckDatabaseHelperTest.java e329ab7
Diff: https://reviews.apache.org/r/43538/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi