You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jscheffl (via GitHub)" <gi...@apache.org> on 2025/07/12 19:53:55 UTC

[PR] Cleanup type ignores in trino provider where possible [airflow]

jscheffl opened a new pull request, #53253:
URL: https://github.com/apache/airflow/pull/53253

   Relates to https://github.com/apache/airflow/issues/53241


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Cleanup type ignores in trino provider where possible [airflow]

Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl merged PR #53253:
URL: https://github.com/apache/airflow/pull/53253


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Cleanup type ignores in trino provider where possible [airflow]

Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on code in PR #53253:
URL: https://github.com/apache/airflow/pull/53253#discussion_r2202915321


##########
providers/trino/src/airflow/providers/trino/hooks/trino.py:
##########
@@ -146,14 +146,14 @@ def __init__(self, *args, **kwargs):
 
     def get_conn(self) -> Connection:
         """Return a connection object."""
-        db = self.get_connection(self.trino_conn_id)  # type: ignore[attr-defined]
+        db = self.get_connection(self.trino_conn_id)

Review Comment:
   @gopidesupavan here it is the same like in https://github.com/apache/airflow/pull/53252#discussion_r2202912638 :-(



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org