You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/06/03 00:14:47 UTC
Review Request 22164: Updated dropped message logging to use VLOG.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22164/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos-git
Description
-------
The number of dropped messages while the master is recovering is quite large. Now that we have counters, there's no need to log these by default.
Diffs
-----
src/master/master.cpp 766a0e36a6e7a615e7b2974d9fee70bcef446719
Diff: https://reviews.apache.org/r/22164/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 22164: Updated dropped message logging to use VLOG.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22164/#review44562
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On June 2, 2014, 10:14 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22164/
> -----------------------------------------------------------
>
> (Updated June 2, 2014, 10:14 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The number of dropped messages while the master is recovering is quite large. Now that we have counters, there's no need to log these by default.
>
>
> Diffs
> -----
>
> src/master/master.cpp 766a0e36a6e7a615e7b2974d9fee70bcef446719
>
> Diff: https://reviews.apache.org/r/22164/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 22164: Updated dropped message logging to use VLOG.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22164/#review44601
-----------------------------------------------------------
Patch looks great!
Reviews applied: [22164]
All tests passed.
- Mesos ReviewBot
On June 2, 2014, 10:14 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22164/
> -----------------------------------------------------------
>
> (Updated June 2, 2014, 10:14 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The number of dropped messages while the master is recovering is quite large. Now that we have counters, there's no need to log these by default.
>
>
> Diffs
> -----
>
> src/master/master.cpp 766a0e36a6e7a615e7b2974d9fee70bcef446719
>
> Diff: https://reviews.apache.org/r/22164/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 22164: Updated dropped message logging to use VLOG.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22164/#review44559
-----------------------------------------------------------
Ship it!
Ship It!
- Jiang Yan Xu
On June 2, 2014, 3:14 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22164/
> -----------------------------------------------------------
>
> (Updated June 2, 2014, 3:14 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The number of dropped messages while the master is recovering is quite large. Now that we have counters, there's no need to log these by default.
>
>
> Diffs
> -----
>
> src/master/master.cpp 766a0e36a6e7a615e7b2974d9fee70bcef446719
>
> Diff: https://reviews.apache.org/r/22164/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>