[GitHub] [arrow] rtpsw commented on a diff in pull request #35878: GH-35838: [C++] Fix asof join backpresure

["rtpsw (via GitHub)" <gi...@apache.org>]

rtpsw commented on code in PR #35878:
URL: https://github.com/apache/arrow/pull/35878#discussion_r1213627756


##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -1407,7 +1407,7 @@ class AsofJoinNode : public ExecNode {
       ARROW_ASSIGN_OR_RAISE(
           auto input_state,
           InputState::Make(i, tolerance_, must_hash_, may_rehash_, key_hashers_[i].get(),
-                           this, inputs[i], backpressure_counter_,
+                           inputs[i], this, backpressure_counter_,

Review Comment:
   Note that I have just added tests in #35874, though this PR can proceed, if so desired.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org