You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "raulcd (via GitHub)" <gi...@apache.org> on 2023/06/08 10:56:23 UTC
[GitHub] [arrow] raulcd commented on issue #35987: [C++] Add support for Protobuf 23.2 on non-Windows
raulcd commented on issue #35987:
URL: https://github.com/apache/arrow/issues/35987#issuecomment-1582368275
> Homebrew is only effected for now. So I think that we can choose "2. Use bundled (old) Protobuf" (`-DProtobuf_SOURCE=BUNDLED`) and it's not a 12.0.1 release blocker.
I am trying to run the verification tasks for MacOS from my fork:
```
archery crossbow submit --job-prefix release-12.0.1-rc1-with-bundled-protobuf --arrow-branch release-12.0.1-rc1-with-bundled-protobuf --arrow-remote "https://github.com/raulcd/arrow" --arrow-version 12.0.1 verify-rc-source-*macos-*
```
Adding the following patch on top of the `release-12.0.1-rc1` branch:
```
$ git log -1 -p
commit 6989adf5de211d72199a6a627ea302338a65eb06 (HEAD -> release-12.0.1-rc1-with-bundled-protobuf, origin/release-12.0.1-rc1-with-bundled-protobuf)
Author: Raúl Cumplido <ra...@gmail.com>
Date: Thu Jun 8 12:23:44 2023 +0200
Try bundled protobuf for verification on macOS
diff --git a/dev/release/verify-release-candidate.sh b/dev/release/verify-release-candidate.sh
index 12e6d9c..080ffa2 100755
--- a/dev/release/verify-release-candidate.sh
+++ b/dev/release/verify-release-candidate.sh
@@ -641,6 +641,7 @@ test_and_install_cpp() {
-DPARQUET_BUILD_EXAMPLES=ON \
-DPARQUET_BUILD_EXECUTABLES=ON \
-DPARQUET_REQUIRE_ENCRYPTION=ON \
+ -DProtobuf_SOURCE=BUNDLED \
${ARROW_CMAKE_OPTIONS:-} \
${ARROW_SOURCE_DIR}/cpp
export CMAKE_BUILD_PARALLEL_LEVEL=${CMAKE_BUILD_PARALLEL_LEVEL:-${NPROC}}
```
And I am getting some failures on protobuf:
```
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:17:2: error: This file was generated by an older version of protoc which is
#error This file was generated by an older version of protoc which is
^
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:18:2: error: incompatible with your Protocol Buffer headers. Please
#error incompatible with your Protocol Buffer headers. Please
^
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:19:2: error: regenerate this file with a newer version of protoc.
#error regenerate this file with a newer version of protoc.
^
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:147:30: error: no type named 'ConstStringParam' in namespace 'google::protobuf'
::PROTOBUF_NAMESPACE_ID::ConstStringParam name, FlightDescriptor_DescriptorType* value) {
~~~~~~~~~~~~~~~~~~~~~~~~~^
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:256:35: error: no type named 'StringPiece' in namespace 'google::protobuf'
static ::PROTOBUF_NAMESPACE_ID::StringPiece FullMessageName() {
~~~~~~~~~~~~~~~~~~~~~~~~~^
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:221:5: error: use of undeclared identifier 'GOOGLE_DCHECK'
GOOGLE_DCHECK(GetOwningArena() == other->GetOwningArena());
^
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:257:12: error: cannot initialize return object of type 'int' with an lvalue of type 'const char [39]'
return "arrow.flight.protocol.HandshakeRequest";
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:420:35: error: no type named 'StringPiece' in namespace 'google::protobuf'
static ::PROTOBUF_NAMESPACE_ID::StringPiece FullMessageName() {
~~~~~~~~~~~~~~~~~~~~~~~~~^
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:385:5: error: use of undeclared identifier 'GOOGLE_DCHECK'
GOOGLE_DCHECK(GetOwningArena() == other->GetOwningArena());
^
[ 38%] Building CXX object src/arrow/acero/CMakeFiles/arrow_acero_objlib.dir/accumulation_queue.cc.o
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:421:12: error: cannot initialize return object of type 'int' with an lvalue of type 'const char [40]'
return "arrow.flight.protocol.HandshakeResponse";
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:584:35: error: no type named 'StringPiece' in namespace 'google::protobuf'
static ::PROTOBUF_NAMESPACE_ID::StringPiece FullMessageName() {
~~~~~~~~~~~~~~~~~~~~~~~~~^
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:549:5: error: use of undeclared identifier 'GOOGLE_DCHECK'
GOOGLE_DCHECK(GetOwningArena() == other->GetOwningArena());
^
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:585:12: error: cannot initialize return object of type 'int' with an lvalue of type 'const char [32]'
return "arrow.flight.protocol.BasicAuth";
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:738:35: error: no type named 'StringPiece' in namespace 'google::protobuf'
static ::PROTOBUF_NAMESPACE_ID::StringPiece FullMessageName() {
~~~~~~~~~~~~~~~~~~~~~~~~~^
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:717:5: error: use of undeclared identifier 'GOOGLE_DCHECK'
GOOGLE_DCHECK(GetOwningArena() == other->GetOwningArena());
^
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:739:12: error: cannot initialize return object of type 'int' with an lvalue of type 'const char [28]'
return "arrow.flight.protocol.Empty";
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:871:35: error: no type named 'StringPiece' in namespace 'google::protobuf'
static ::PROTOBUF_NAMESPACE_ID::StringPiece FullMessageName() {
~~~~~~~~~~~~~~~~~~~~~~~~~^
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:836:5: error: use of undeclared identifier 'GOOGLE_DCHECK'
GOOGLE_DCHECK(GetOwningArena() == other->GetOwningArena());
^
/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.vQ2csunE/cpp-build/src/arrow/flight/Flight.pb.h:872:12: error: cannot initialize return object of type 'int' with an lvalue of type 'const char [33]'
return "arrow.flight.protocol.ActionType";
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
fatal error: too many errors emitted, stopping now [-ferror-limit=]
```
Examples:
https://github.com/ursacomputing/crossbow/actions/runs/5210265087/jobs/9401119933
https://github.com/ursacomputing/crossbow/actions/runs/5210265256/jobs/9401120122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org