[GitHub] [hbase] wchevreuil commented on a change in pull request #2249: HBASE-24871 Replication may loss data when refresh recovered replicat…

[GitBox <gi...@apache.org>]

wchevreuil commented on a change in pull request #2249:
URL: https://github.com/apache/hbase/pull/2249#discussion_r469839728



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
##########
@@ -516,7 +516,7 @@ public void refreshSources(String peerId) throws IOException {
         ReplicationSourceInterface replicationSource = createSource(queueId, peer);
         this.oldsources.add(replicationSource);
         for (SortedSet<String> walsByGroup : walsByIdRecoveredQueues.get(queueId).values()) {
-          walsByGroup.forEach(wal -> src.enqueueLog(new Path(wal)));
+          walsByGroup.forEach(wal -> replicationSource.enqueueLog(new Path(wal)));

Review comment:
       So the problem is that logs from recovered queues were getting added to the new "normal" queue? And these logs are never read, then? 
   
   Nit: maybe worth rename the variable from line #516 from `replicationSource` to `recoveredReplicationSource`, for further clarity?
   
   I endorse the call for an additional UT, here. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org