[GitHub] [airflow] ashb commented on a change in pull request #21501: Support different timeout value for dag file parsing

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #21501:
URL: https://github.com/apache/airflow/pull/21501#discussion_r804637903



##########
File path: airflow/models/dagbag.py
##########
@@ -310,13 +310,7 @@ def _load_modules_from_file(self, filepath, safe_mode):
         if mod_name in sys.modules:
             del sys.modules[mod_name]
 
-        timeout_msg = (
-            f"DagBag import timeout for {filepath} after {self.DAGBAG_IMPORT_TIMEOUT}s.\n"
-            "Please take a look at these docs to improve your DAG import time:\n"
-            f"* {get_docs_url('best-practices.html#top-level-python-code')}\n"
-            f"* {get_docs_url('best-practices.html#reducing-dag-complexity')}"
-        )
-        with timeout(self.DAGBAG_IMPORT_TIMEOUT, error_message=timeout_msg):

Review comment:
       This constant isn't used anymore either is it? We should remove it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org