You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by zh...@apache.org on 2023/12/13 01:38:52 UTC

(shardingsphere) branch master updated: Refactor ConfigMetaDataChangedEventHandler (#29383)

This is an automated email from the ASF dual-hosted git repository.

zhonghongsheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new cd56afbf318 Refactor ConfigMetaDataChangedEventHandler (#29383)
cd56afbf318 is described below

commit cd56afbf318c2259eb5fa31d5708df52ed66994e
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Wed Dec 13 09:38:46 2023 +0800

    Refactor ConfigMetaDataChangedEventHandler (#29383)
---
 .../node/event/handler/impl/ConfigMetaDataChangedEventHandler.java   | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/metadata/node/event/handler/impl/ConfigMetaDataChangedEventHandler.java b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/metadata/node/event/handler/impl/ConfigMetaDataChangedEventHandler.java
index 68618929fcf..e18f90fa10c 100644
--- a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/metadata/node/event/handler/impl/ConfigMetaDataChangedEventHandler.java
+++ b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/metadata/node/event/handler/impl/ConfigMetaDataChangedEventHandler.java
@@ -42,6 +42,7 @@ public final class ConfigMetaDataChangedEventHandler implements PipelineMetaData
         return PipelineMetaDataNode.CONFIG_PATTERN;
     }
     
+    @SuppressWarnings("unchecked")
     @Override
     public void handle(final String jobId, final DataChangedEvent event) {
         JobConfiguration jobConfig;
@@ -54,7 +55,7 @@ public final class ConfigMetaDataChangedEventHandler implements PipelineMetaData
             return;
         }
         log.info("{} job configuration: {}, disabled={}", event.getType(), event.getKey(), jobConfig.isDisabled());
-        TypedSPILoader.findService(JobConfigurationChangedProcessor.class, PipelineJobIdUtils.parseJobType(jobConfig.getJobName()).getType()).ifPresent(
-                optional -> new JobConfigurationChangedProcessEngine().process(event.getType(), jobConfig, optional));
+        String jobType = PipelineJobIdUtils.parseJobType(jobConfig.getJobName()).getType();
+        TypedSPILoader.findService(JobConfigurationChangedProcessor.class, jobType).ifPresent(optional -> new JobConfigurationChangedProcessEngine().process(event.getType(), jobConfig, optional));
     }
 }