You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2021/01/27 23:02:57 UTC

Review Request 73162: RANGER-2724: Support EXECUTE permission in HBase Authorisation - Part 2

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73162/
-----------------------------------------------------------

Review request for ranger, Madhan Neethiraj, Mehul Parikh, and Velmurugan Periasamy.


Bugs: RANGER-2724
    https://issues.apache.org/jira/browse/RANGER-2724


Repository: ranger


Description
-------

Add missing Java patch to ensure that default policy grants execute privilege to hbase user.


Diffs
-----

  security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql cc73e0b5f 
  security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 6556a096a 
  security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql d734222c4 
  security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql f1d67be91 
  security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 80307af38 
  security-admin/src/main/java/org/apache/ranger/patch/PatchForHBaseDefaultPolicyUpdate_J10045.java PRE-CREATION 


Diff: https://reviews.apache.org/r/73162/diff/1/


Testing
-------


Thanks,

Abhay Kulkarni


Re: Review Request 73162: RANGER-2724: Support EXECUTE permission in HBase Authorisation - Part 2

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73162/#review222537
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Jan. 28, 2021, 2:08 a.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73162/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2021, 2:08 a.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj, Mehul Parikh, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2724
>     https://issues.apache.org/jira/browse/RANGER-2724
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Add missing Java patch to ensure that default policy grants execute privilege to hbase user.
> 
> 
> Diffs
> -----
> 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql cc73e0b5f 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 6556a096a 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql d734222c4 
>   security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql f1d67be91 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 80307af38 
>   security-admin/src/main/java/org/apache/ranger/patch/PatchForHBaseDefaultPolicyUpdate_J10045.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73162/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>


Re: Review Request 73162: RANGER-2724: Support EXECUTE permission in HBase Authorisation - Part 2

Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73162/
-----------------------------------------------------------

(Updated Jan. 28, 2021, 2:08 a.m.)


Review request for ranger, Madhan Neethiraj, Mehul Parikh, and Velmurugan Periasamy.


Changes
-------

Addressed review comments


Bugs: RANGER-2724
    https://issues.apache.org/jira/browse/RANGER-2724


Repository: ranger


Description
-------

Add missing Java patch to ensure that default policy grants execute privilege to hbase user.


Diffs (updated)
-----

  security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql cc73e0b5f 
  security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 6556a096a 
  security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql d734222c4 
  security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql f1d67be91 
  security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 80307af38 
  security-admin/src/main/java/org/apache/ranger/patch/PatchForHBaseDefaultPolicyUpdate_J10045.java PRE-CREATION 


Diff: https://reviews.apache.org/r/73162/diff/2/

Changes: https://reviews.apache.org/r/73162/diff/1-2/


Testing
-------


Thanks,

Abhay Kulkarni


Re: Review Request 73162: RANGER-2724: Support EXECUTE permission in HBase Authorisation - Part 2

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73162/#review222536
-----------------------------------------------------------




security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql
Line 1830 (original)
<https://reviews.apache.org/r/73162/#comment311643>

    addition of J10045 for the new patch is good. However, are the changes for J10030 and J10042 necessary?



security-admin/src/main/java/org/apache/ranger/patch/PatchForHBaseDefaultPolicyUpdate_J10045.java
Lines 109 (patched)
<https://reviews.apache.org/r/73162/#comment311642>

    is SERVICE_NAME filter needed, given serviceId is sent as parameter in #110 below?


- Madhan Neethiraj


On Jan. 27, 2021, 11:02 p.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73162/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2021, 11:02 p.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj, Mehul Parikh, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2724
>     https://issues.apache.org/jira/browse/RANGER-2724
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Add missing Java patch to ensure that default policy grants execute privilege to hbase user.
> 
> 
> Diffs
> -----
> 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql cc73e0b5f 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 6556a096a 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql d734222c4 
>   security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql f1d67be91 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 80307af38 
>   security-admin/src/main/java/org/apache/ranger/patch/PatchForHBaseDefaultPolicyUpdate_J10045.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73162/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>