[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2427: style: remove unnecessary trailing whitespace

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on a change in pull request #2427:
URL: https://github.com/apache/incubator-nuttx/pull/2427#discussion_r531952588



##########
File path: tools/configure.bat
##########
@@ -1,158 +1,158 @@
-@echo off
-
-rem tools/configure.bat
-rem
-rem   Copyright (C) 2012, 2017 Gregory Nutt. All rights reserved.
-rem   Author: Gregory Nutt <gn...@nuttx.org>
-rem
-rem Redistribution and use in source and binary forms, with or without
-rem modification, are permitted provided that the following conditions
-rem are met:
-rem
-rem 1. Redistributions of source code must retain the above copyright
-rem    notice, this list of conditions and the following disclaimer.
-rem 2. Redistributions in binary form must reproduce the above copyright
-rem    notice, this list of conditions and the following disclaimer in
-rem    the documentation and/or other materials provided with the
-rem    distribution.
-rem 3. Neither the name NuttX nor the names of its contributors may be
-rem    used to endorse or promote products derived from this software
-rem    without specific prior written permission.
-rem
-rem THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-rem "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-rem LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
-rem FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
-rem COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
-rem INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
-rem BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
-rem OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
-rem AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
-rem LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
-rem ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
-rem POSSIBILITY OF SUCH DAMAGE.
-rem
-
-if exist tools goto :GoToolDir
-if exist ..\tools goto :SetToolDir
-
-echo Cannot find tools\ directory
-goto End
-
-:GoToolDir
-cd tools
-
-:SetTooldir
-set tooldir=%CD%
-
-rem Parse command line arguments
-
-set debug=
-set fmt=-b
-set posix=
-set help=
-set appdir=
-set config=
-set hostopt=
-
-:ArgLoop
-if "%1"=="" goto :NoConfig
-if "%1"=="-h" goto :ShowUsage
-if "%1"=="-d" goto :SetDebug
-if "%1"=="-f" goto :SetFormat
-if "%1"=="-b" goto :SetFormat
-if "%1"=="-l" goto :SetHostOption
-if "%1"=="-c" goto :SetHostOption
-if "%1"=="-n" goto :SetHostOption
-if "%1"=="-L" goto :SetList
-if "%1"=="-a" goto :SetAppDir
-
-set config=%1
-goto EndOfLoop
-
-:SetDebug
-set debug=%1
-goto :NextArg
-
-:SetFormat
-set fmt=%1
-goto :NextArg
-
-:SetHostOption
-set hostopt=%1
-goto :NextArg
-
-:SetList
-set list=%1
-goto :EndOfLoop
-
-:SetAppDir
-shift
-set appdir=-a %1
-
-:NextArg
-shift
-goto :ArgLoop
-
-:EndOfLoop
-
-rem Check if we have to build configure.exe
-
-if exist configure.exe goto :HaveConfigureExe
-
-set cc=mingw32-gcc.exe
-set cflags=-Wall -Wstrict-prototypes -Wshadow -g -pipe -I. -DCONFIG_WINDOWS_NATIVE=y
-echo %cc% %cflags% -o configure.exe configure.c cfgparser.c
-%cc% %cflags% -o configure.exe configure.c cfgparser.c
-if errorlevel 1 (
-  echo ERROR: %cc% failed
-  echo Is ming32-gcc.exe installed?  Is it in the PATH variable?
-  goto End
-)
-
-:HaveConfigureExe
-cd ..
-tools\configure.exe %debug% %fmt% %hostopt% %appdir% %config% %list%
-if errorlevel 1 echo configure.exe failed
-goto End
-
-:NoConfig
-echo Missing ^<board-name^>:^<config-name^> argument
-
-:ShowUsage
-echo USAGE: %0 [-d] [-b|f] [-a ^<app-dir^>] ^<board-name^>:^<config-name^>
-echo        %0 [-h]
-echo\nWhere:
-echo  -d:
-echo    Enables debug output
-echo  -b:
-echo    Informs the tool that it should use Windows style paths like C:\\Program Files
-echo    instead of POSIX style paths are used like /usr/local/bin.  Windows
-echo    style paths are used by default.
-echo  -f:
-echo    Informs the tool that it should use POSIX style paths like /usr/local/bin.
-echo    By default, Windows style paths like C:\\Program Files are used.
-echo  -l selects the Linux (l) host environment.  The [-c^|n] options
-echo    select one of the Windows environments.  Default:  Use host setup
-echo    in the defconfig file
-echo  [-c^|n] selects the Windows host and a Windows environment:
-echo    Cygwin (c), or Windows native (n). Default Cygwin
-echo  -L:
-echo    List all available configurations.
-echo  -a ^<app-dir^>:
-echo    Informs the configuration tool where the application build
-echo    directory.  This is a relative path from the top-level NuttX
-echo    build directory.  But default, this tool will look in the usual
-echo    places to try to locate the application directory:  ../apps or
-echo    ../apps-xx.yy where xx.yy is the NuttX version number.
-echo  ^<board-name^>:
-echo    Identifies the board.  This must correspond to a board directory
-echo    under nuttx/boards/.
-echo  ^<config-name^>:
-echo    Identifies the specific configuration for the selected ^<board-name^>.
-echo    This must correspond to a sub-directory under the board directory at
-echo    under nuttx/boards/^<board-name^>/configs/.
-echo  -h:
-echo    Prints this message and exits.
-
-:End
+@echo off
+
+rem tools/configure.bat

Review comment:
       @anchao look like the script handle \r\n incorrectly?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org