[GitHub] [wicket] svenmeier commented on issue #361: WICKET-6666 initial checkin of new ModalDialog

[GitBox <gi...@apache.org>]

svenmeier commented on issue #361: WICKET-6666 initial checkin of new ModalDialog
URL: https://github.com/apache/wicket/pull/361#issuecomment-492198078
 
 
   Thanks Igor, it's much easier to start with something instead of starting from scratch.
   
   I would like to improve some general points:
   
   - body>overlay>form>content
   ModalDialog replicates what ModalWindow has done: its JS creates some wrapping HTML, moves the dialog's content inside of it and appends everything to the body. I think it would be simpler to leave the dialog where it is in the DOM: then we don't have to create markup from JS, no extra form is required and it works without JavaScript too (yes, call me old-school).
   
   - behaviors
   ModalDialog has its own pure-JS 'behavior' solution. We can make these Wicket-behaviors, so they are modular and reuasable: some projects will not need all of them, want to replace them with their own or add custom ones (e.g. resizing).
   
   - styling
   ModalDialog offers sort of a default skin: I'd like to make this a behavior with a base CSS selector (similar to 'themes' of Palette and AbstractTree) - this makes it possible to use different styles on a single page simultaneously (e.g. a simple warning dialog vs. an larger one with an input form).
   
   - multiple/nested dialogs
   Many elements are modified via CSS class selector, we'll have to improve that to support multiple dialogs.
   
   - options.console
   IMHO we can simply call Wicket.Log.* (see recent "js-cleanup" discussion)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services