You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/07/27 23:49:53 UTC
[kudu-CR] clang tidy gerrit.py: add a local mode
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7528
to review the following change.
Change subject: clang_tidy_gerrit.py: add a local mode
......................................................................
clang_tidy_gerrit.py: add a local mode
This patch makes it possible to run clang_tidy_gerrit.py "locally" (i.e.
without posting anything to gerrit). The new argument parsing is such that
regular clang_tidy_gerrit.py runs should continue to work unmolested.
Here is some sample output:
$ build-support/clang_tidy_gerrit.py -n HEAD
42349 warnings generated.
83338 warnings generated.
Suppressed 83398 warnings (83331 in non-user code, 5 due to line filter, 61 NOLINT, 1 with check filters).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
INFO:root:Clang output
INFO:root:/home/adar/Source/kudu/src/kudu/consensus/raft_consensus.cc:2253:69: warning: the parameter 'client_cb' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
StdStatusCallback client_cb,
^
Skipping gerrit
Change-Id: I2910d32e4318eea4ca947c52717ee386063fa45f
---
M build-support/clang_tidy_gerrit.py
1 file changed, 19 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/7528/1
--
To view, visit http://gerrit.cloudera.org:8080/7528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2910d32e4318eea4ca947c52717ee386063fa45f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] clang tidy gerrit.py: add a local mode
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: clang_tidy_gerrit.py: add a local mode
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2910d32e4318eea4ca947c52717ee386063fa45f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] clang tidy gerrit.py: add a local mode
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: clang_tidy_gerrit.py: add a local mode
......................................................................
clang_tidy_gerrit.py: add a local mode
This patch makes it possible to run clang_tidy_gerrit.py "locally" (i.e.
without posting anything to gerrit). The new argument parsing is such that
regular clang_tidy_gerrit.py runs should continue to work unmolested.
Here is some sample output:
$ build-support/clang_tidy_gerrit.py -n HEAD
42349 warnings generated.
83338 warnings generated.
Suppressed 83398 warnings (83331 in non-user code, 5 due to line filter, 61 NOLINT, 1 with check filters).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
INFO:root:Clang output
INFO:root:/home/adar/Source/kudu/src/kudu/consensus/raft_consensus.cc:2253:69: warning: the parameter 'client_cb' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
StdStatusCallback client_cb,
^
Skipping gerrit
Change-Id: I2910d32e4318eea4ca947c52717ee386063fa45f
Reviewed-on: http://gerrit.cloudera.org:8080/7528
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M build-support/clang_tidy_gerrit.py
1 file changed, 19 insertions(+), 5 deletions(-)
Approvals:
Adar Dembo: Verified
Todd Lipcon: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2910d32e4318eea4ca947c52717ee386063fa45f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] clang tidy gerrit.py: add a local mode
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: clang_tidy_gerrit.py: add a local mode
......................................................................
Patch Set 1: Verified+1
Overriding Jenkins, there's no way this change could cause a unit test to fail.
--
To view, visit http://gerrit.cloudera.org:8080/7528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2910d32e4318eea4ca947c52717ee386063fa45f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] clang tidy gerrit.py: add a local mode
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: clang_tidy_gerrit.py: add a local mode
......................................................................
Patch Set 1:
ha, I almost wrote the same patch earlier today. glad I didn't
--
To view, visit http://gerrit.cloudera.org:8080/7528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2910d32e4318eea4ca947c52717ee386063fa45f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No