[GitHub] [airflow] josh-fell commented on a change in pull request #19563: Add example SLA DAG

[GitBox <gi...@apache.org>]

josh-fell commented on a change in pull request #19563:
URL: https://github.com/apache/airflow/pull/19563#discussion_r748543962



##########
File path: airflow/example_dags/example_sla_dag.py
##########
@@ -0,0 +1,56 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import time
+from datetime import datetime, timedelta
+
+from airflow.decorators import dag, task
+
+"""Example DAG demonstrating SLA use in Tasks"""
+
+
+# [START howto_task_sla]
+def sla_callback(*args):

Review comment:
       WDYT about having the same function name in the SLA Concepts guide and this example DAG? I'm thinking the SLA Concepts guide is a detailed breakdown of SLAs and this example DAG pulls it all together at the end. Having the functions named the same seems like a great way to bring some continuity to the doc.

##########
File path: airflow/example_dags/example_sla_dag.py
##########
@@ -0,0 +1,56 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import time
+from datetime import datetime, timedelta
+
+from airflow.decorators import dag, task
+
+"""Example DAG demonstrating SLA use in Tasks"""
+
+
+# [START howto_task_sla]
+def sla_callback(*args):
+    arguments = ["dag", "task_list", "blocking_task_list", "slas", "blocking_tis"]
+    print(*zip(arguments, args))
+
+
+@dag(
+    "example_sla_dag",

Review comment:
       Including the `dag_id` in the decorator isn't necessary since the `dag_id` will default to the function name being decorated. No strong opinion here though. It's more of a stylistic comment.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org