[jira] [Commented] (BEAM-762) Use composition over inheritance in spark StreamingEvaluationContext if two contexts are necessary.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15644415#comment-15644415 ] 

ASF GitHub Bot commented on BEAM-762:
-------------------------------------

GitHub user aviemzur opened a pull request:

    https://github.com/apache/incubator-beam/pull/1291

    [BEAM-762] Unify spark-runner EvaluationContext and StreamingEvaluationContext

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aviemzur/incubator-beam refactor-spark-runner-evaluation-context

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1291.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1291
    
----
commit 7f6851d6eb1a17de85c3d87407da3a678a281b83
Author: Aviem Zur <av...@gmail.com>
Date:   2016-11-07T12:51:19Z

    Unify spark-runner EvaluationContext and StreamingEvaluationContext

----


> Use composition over inheritance in spark StreamingEvaluationContext if two contexts are necessary.
> ---------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-762
>                 URL: https://issues.apache.org/jira/browse/BEAM-762
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-spark
>            Reporter: Pei He
>            Priority: Minor
>              Labels: starter
>
> After working on PR: https://github.com/apache/incubator-beam/pull/1096 ,
> I felt it is easy to forget updating spark streaming context with current inheritance.
> And, having a single EvaluationContext to support both streaming and batch is even better.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)