You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/03/22 17:03:39 UTC
[GitHub] [camel-k-runtime] tplevko opened a new pull request #643: fix(examples) - update path to runner.jar
tplevko opened a new pull request #643:
URL: https://github.com/apache/camel-k-runtime/pull/643
<!-- Description -->
The issue with the examples was caused by change in the structure of built quarkus projects after the upgrade for more info about the issue see: https://github.com/apache/camel-k-runtime/issues/641
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
fix(examples) - update path to runner.jar
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] lburgazzoli commented on pull request #643: fix(examples) - update path to runner.jar
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on pull request #643:
URL: https://github.com/apache/camel-k-runtime/pull/643#issuecomment-804727535
@tplevko the quarkus team has added support for system properties and env vars [1][2] to the quarkus:dev mojo, wonder if the examples should leverage quarkus:dev to run the examples and support running them in jvm mode only
[1] https://github.com/quarkusio/quarkus/issues/14401
[2] https://github.com/quarkusio/quarkus/pull/14523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] lburgazzoli merged pull request #643: fix(examples) - update path to runner.jar
Posted by GitBox <gi...@apache.org>.
lburgazzoli merged pull request #643:
URL: https://github.com/apache/camel-k-runtime/pull/643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] lburgazzoli commented on pull request #643: fix(examples) - update path to runner.jar
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on pull request #643:
URL: https://github.com/apache/camel-k-runtime/pull/643#issuecomment-808223729
> @lburgazzoli what you are proposing sounds great. One thing that however that crossed my mind is if this wouldn't hide the key features of the runtime for a newcomer to this runtime (e.g. someone like me). Couldn't it be added as one of the options how to run the examples, leaving the native mode as it is now?
>
I think we can keep the native build, may require a little bit more work but yes, it should be possible.
> Anyway, I am not sure this is something I am too knowledgeable about, these are just my observations. I was in this PR just trying to get the examples to work.
>
I'll try to do it once this get merged, unless you want to try to do it yourself.
> Also I would like to ask, whether there is some issue with the checks, or I should investigate what might have caused the failures. I'm not really aware what might have caused the failures in the automation.
Restarted the job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] tplevko commented on pull request #643: fix(examples) - update path to runner.jar
Posted by GitBox <gi...@apache.org>.
tplevko commented on pull request #643:
URL: https://github.com/apache/camel-k-runtime/pull/643#issuecomment-808243436
Thanks for the rerun, it seems like it helped.
> I'll try to do it once this get merged, unless you want to try to do it yourself.
Sounds great, I can definitely try to do it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] tplevko commented on pull request #643: fix(examples) - update path to runner.jar
Posted by GitBox <gi...@apache.org>.
tplevko commented on pull request #643:
URL: https://github.com/apache/camel-k-runtime/pull/643#issuecomment-808209575
@lburgazzoli what you are proposing sounds great. One thing that however that crossed my mind is if this wouldn't hide the key features of the runtime for a newcomer to this runtime (e.g. someone like me). Couldn't it be added as one of the options how to run the examples, leaving the native mode as it is now?
Anyway, I am not sure this is something I am too knowledgeable about, these are just my observations. I was in this PR just trying to get the examples to work.
Also I would like to ask, whether there is some issue with the checks, or I should investigate what might have caused the failures. I'm not really aware what might have caused the failures in the automation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] lburgazzoli commented on pull request #643: fix(examples) - update path to runner.jar
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on pull request #643:
URL: https://github.com/apache/camel-k-runtime/pull/643#issuecomment-808252366
@tplevko thx for fixing this, if you need any support, ping me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org