You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/02/12 11:40:03 UTC
[GitHub] [incubator-dolphinscheduler] qiaozhanwei opened a new pull request
#1946: Refactor Architecture Basic modification #1658
qiaozhanwei opened a new pull request #1946: Refactor Architecture Basic modification #1658
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946
Refactor Architecture Basic modification #1658
1，remove dolphinscheduler-rpc module
2，add dolphinscheduler-remote
3，add dolphinscheduler-service module
4，refactor LoggerServer module
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1946: Refactor Architecture Basic modification #1658
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1946: Refactor Architecture Basic modification #1658
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946#issuecomment-585172652
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=h1) Report
> Merging [#1946](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/822b9b4e7a95fe7428a2d61cb763f105c6844efb?src=pr&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1946 +/- ##
============================================
+ Coverage 29.03% 29.07% +0.04%
Complexity 1314 1314
============================================
Files 294 294
Lines 14989 14987 -2
Branches 1810 1809 -1
============================================
+ Hits 4352 4358 +6
+ Misses 10202 10193 -9
- Partials 435 436 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...dolphinscheduler/api/utils/FourLetterWordMain.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3V0aWxzL0ZvdXJMZXR0ZXJXb3JkTWFpbi5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...cheduler/api/service/ProcessDefinitionService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvY2Vzc0RlZmluaXRpb25TZXJ2aWNlLmphdmE=) | `51.94% <0%> (+0.16%)` | `60% <0%> (ø)` | :arrow_down: |
| [...er/server/worker/task/AbstractCommandExecutor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL0Fic3RyYWN0Q29tbWFuZEV4ZWN1dG9yLmphdmE=) | `42.13% <0%> (+2.03%)` | `14% <0%> (ø)` | :arrow_down: |
| [...scheduler/alert/template/AlertTemplateFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9BbGVydFRlbXBsYXRlRmFjdG9yeS5qYXZh) | `57.14% <0%> (+14.28%)` | `2% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=footer). Last update [822b9b4...c1bba46](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on
issue #1946: Refactor Architecture Basic modification #1658
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on issue #1946: Refactor Architecture Basic modification #1658
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946#issuecomment-585174053
SonarCloud Quality Gate failed.
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='0.7%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1946&metric=new_coverage&view=list) [0.7% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1946&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/5.png' alt='3.2%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1946&metric=new_duplicated_lines_density&view=list) [3.2% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1946&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1946: Refactor Architecture Basic modification #1658
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1946: Refactor Architecture Basic modification #1658
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946#issuecomment-585172652
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=h1) Report
> Merging [#1946](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/fb5de1784e22072d0597e51d6c7de5a6c126bfbf?src=pr&el=desc) will **increase** coverage by `0.45%`.
> The diff coverage is `48.93%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1946 +/- ##
============================================
+ Coverage 28.57% 29.03% +0.45%
- Complexity 1295 1314 +19
============================================
Files 294 294
Lines 14985 14989 +4
Branches 1808 1810 +2
============================================
+ Hits 4282 4352 +70
+ Misses 10272 10202 -70
- Partials 431 435 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...hinscheduler/dao/datasource/ConnectionFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvQ29ubmVjdGlvbkZhY3RvcnkuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...e/dolphinscheduler/server/worker/WorkerServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9Xb3JrZXJTZXJ2ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...er/server/worker/task/AbstractCommandExecutor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL0Fic3RyYWN0Q29tbWFuZEV4ZWN1dG9yLmphdmE=) | `40.1% <0%> (ø)` | `14 <0> (ø)` | :arrow_down: |
| [...apache/dolphinscheduler/alert/utils/Constants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9Db25zdGFudHMuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...he/dolphinscheduler/server/utils/ProcessUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1Byb2Nlc3NVdGlscy5qYXZh) | `16.54% <0%> (-0.5%)` | `8 <0> (ø)` | |
| [.../apache/dolphinscheduler/api/utils/CheckUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3V0aWxzL0NoZWNrVXRpbHMuamF2YQ==) | `61.53% <0%> (+9.53%)` | `19 <0> (+3)` | :arrow_up: |
| [...dolphinscheduler/api/service/ResourcesService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUmVzb3VyY2VzU2VydmljZS5qYXZh) | `79.66% <0%> (ø)` | `67 <0> (ø)` | :arrow_down: |
| [...r/common/task/subprocess/SubProcessParameters.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svc3VicHJvY2Vzcy9TdWJQcm9jZXNzUGFyYW1ldGVycy5qYXZh) | `16.66% <0%> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [...che/dolphinscheduler/common/utils/CommonUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0NvbW1vblV0aWxzLmphdmE=) | `40% <0%> (+40%)` | `5 <0> (+5)` | :arrow_up: |
| [...scheduler/dao/datasource/ClickHouseDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvQ2xpY2tIb3VzZURhdGFTb3VyY2UuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| ... and [13 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=footer). Last update [fb5de17...822b9b4](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1946: Refactor Architecture Basic modification #1658
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1946: Refactor Architecture Basic modification #1658
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946#issuecomment-585172652
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=h1) Report
> Merging [#1946](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/fb5de1784e22072d0597e51d6c7de5a6c126bfbf?src=pr&el=desc) will **decrease** coverage by `4.67%`.
> The diff coverage is `45.45%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1946 +/- ##
============================================
- Coverage 28.57% 23.89% -4.68%
============================================
Files 294 322 +28
Lines 14985 14789 -196
Branches 1808 2400 +592
============================================
- Hits 4282 3534 -748
- Misses 10272 10845 +573
+ Partials 431 410 -21
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...dolphinscheduler/service/log/LogClientService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvbG9nL0xvZ0NsaWVudFNlcnZpY2UuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...he/dolphinscheduler/server/utils/ProcessUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1Byb2Nlc3NVdGlscy5qYXZh) | `16.42% <0%> (-0.61%)` | `0 <0> (-8)` | |
| [...he/dolphinscheduler/api/service/LoggerService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvTG9nZ2VyU2VydmljZS5qYXZh) | `85.71% <71.42%> (-14.29%)` | `0 <0> (-7)` | |
| [...phinscheduler/common/enums/HttpCheckCondition.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL0h0dHBDaGVja0NvbmRpdGlvbi5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (-1%)` | |
| [...ache/dolphinscheduler/common/enums/HttpMethod.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL0h0dHBNZXRob2QuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (-1%)` | |
| [...che/dolphinscheduler/common/enums/ProgramType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL1Byb2dyYW1UeXBlLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (-1%)` | |
| [...phinscheduler/api/service/DataAnalysisService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvRGF0YUFuYWx5c2lzU2VydmljZS5qYXZh) | `0.6% <0%> (-81.06%)` | `0% <0%> (-21%)` | |
| [...apache/dolphinscheduler/common/enums/TaskType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL1Rhc2tUeXBlLmphdmE=) | `0% <0%> (-80%)` | `0% <0%> (-2%)` | |
| [...hinscheduler/common/utils/TaskParametersUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1Rhc2tQYXJhbWV0ZXJzVXRpbHMuamF2YQ==) | `0% <0%> (-77.78%)` | `0% <0%> (-11%)` | |
| [...che/dolphinscheduler/common/utils/SchemaUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1NjaGVtYVV0aWxzLmphdmE=) | `0% <0%> (-77.56%)` | `0% <0%> (-14%)` | |
| ... and [303 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=footer). Last update [fb5de17...822b9b4](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1946: Refactor Architecture Basic modification #1658
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1946: Refactor Architecture Basic modification #1658
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946#issuecomment-585172652
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=h1) Report
> Merging [#1946](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/fb5de1784e22072d0597e51d6c7de5a6c126bfbf?src=pr&el=desc) will **increase** coverage by `0.45%`.
> The diff coverage is `44.82%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1946 +/- ##
============================================
+ Coverage 28.57% 29.02% +0.45%
- Complexity 1295 1314 +19
============================================
Files 294 294
Lines 14985 14979 -6
Branches 1808 1807 -1
============================================
+ Hits 4282 4348 +66
+ Misses 10272 10198 -74
- Partials 431 433 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...hinscheduler/dao/datasource/ConnectionFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvQ29ubmVjdGlvbkZhY3RvcnkuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...e/dolphinscheduler/server/worker/WorkerServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9Xb3JrZXJTZXJ2ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...er/server/worker/task/AbstractCommandExecutor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL0Fic3RyYWN0Q29tbWFuZEV4ZWN1dG9yLmphdmE=) | `40.1% <0%> (ø)` | `14 <0> (ø)` | :arrow_down: |
| [...apache/dolphinscheduler/alert/utils/Constants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9Db25zdGFudHMuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../apache/dolphinscheduler/api/utils/CheckUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3V0aWxzL0NoZWNrVXRpbHMuamF2YQ==) | `61.53% <0%> (+9.53%)` | `19 <0> (+3)` | :arrow_up: |
| [...dolphinscheduler/api/service/ResourcesService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUmVzb3VyY2VzU2VydmljZS5qYXZh) | `79.66% <0%> (ø)` | `67 <0> (ø)` | :arrow_down: |
| [...r/common/task/subprocess/SubProcessParameters.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svc3VicHJvY2Vzcy9TdWJQcm9jZXNzUGFyYW1ldGVycy5qYXZh) | `16.66% <0%> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [...che/dolphinscheduler/common/utils/CommonUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0NvbW1vblV0aWxzLmphdmE=) | `40% <0%> (+40%)` | `5 <0> (+5)` | :arrow_up: |
| [...scheduler/dao/datasource/ClickHouseDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvQ2xpY2tIb3VzZURhdGFTb3VyY2UuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...e/dolphinscheduler/server/master/MasterServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9NYXN0ZXJTZXJ2ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=footer). Last update [fb5de17...ad00268](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] qiaozhanwei commented on issue #1946:
Refactor Architecture Basic modification #1658
Posted by GitBox <gi...@apache.org>.
qiaozhanwei commented on issue #1946: Refactor Architecture Basic modification #1658
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946#issuecomment-585674561
@dailidong @lgcareer @lenboo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1946:
Refactor Architecture Basic modification #1658
Posted by GitBox <gi...@apache.org>.
qiaozhanwei merged pull request #1946: Refactor Architecture Basic modification #1658
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue
#1946: Refactor Architecture Basic modification #1658
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on issue #1946: Refactor Architecture Basic modification #1658
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946#issuecomment-585664419
SonarCloud Quality Gate failed.
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='0.7%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1946&metric=new_coverage&view=list) [0.7% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1946&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/5.png' alt='3.6%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1946&metric=new_duplicated_lines_density&view=list) [3.6% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1946&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1946: Refactor Architecture Basic modification #1658
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1946: Refactor Architecture Basic modification #1658
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946#issuecomment-585172652
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=h1) Report
> Merging [#1946](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/fb5de1784e22072d0597e51d6c7de5a6c126bfbf?src=pr&el=desc) will **increase** coverage by `0.45%`.
> The diff coverage is `44.82%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1946 +/- ##
============================================
+ Coverage 28.57% 29.02% +0.45%
- Complexity 1295 1314 +19
============================================
Files 294 294
Lines 14985 14979 -6
Branches 1808 1807 -1
============================================
+ Hits 4282 4348 +66
+ Misses 10272 10198 -74
- Partials 431 433 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...hinscheduler/dao/datasource/ConnectionFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvQ29ubmVjdGlvbkZhY3RvcnkuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...e/dolphinscheduler/server/worker/WorkerServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9Xb3JrZXJTZXJ2ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...er/server/worker/task/AbstractCommandExecutor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL0Fic3RyYWN0Q29tbWFuZEV4ZWN1dG9yLmphdmE=) | `40.1% <0%> (ø)` | `14 <0> (ø)` | :arrow_down: |
| [...apache/dolphinscheduler/alert/utils/Constants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9Db25zdGFudHMuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../apache/dolphinscheduler/api/utils/CheckUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3V0aWxzL0NoZWNrVXRpbHMuamF2YQ==) | `61.53% <0%> (+9.53%)` | `19 <0> (+3)` | :arrow_up: |
| [...dolphinscheduler/api/service/ResourcesService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUmVzb3VyY2VzU2VydmljZS5qYXZh) | `79.66% <0%> (ø)` | `67 <0> (ø)` | :arrow_down: |
| [...r/common/task/subprocess/SubProcessParameters.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svc3VicHJvY2Vzcy9TdWJQcm9jZXNzUGFyYW1ldGVycy5qYXZh) | `16.66% <0%> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [...che/dolphinscheduler/common/utils/CommonUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0NvbW1vblV0aWxzLmphdmE=) | `40% <0%> (+40%)` | `5 <0> (+5)` | :arrow_up: |
| [...scheduler/dao/datasource/ClickHouseDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvQ2xpY2tIb3VzZURhdGFTb3VyY2UuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...e/dolphinscheduler/server/master/MasterServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9NYXN0ZXJTZXJ2ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=footer). Last update [fb5de17...ad00268](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue
#1946: Refactor Architecture Basic modification #1658
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on issue #1946: Refactor Architecture Basic modification #1658
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946#issuecomment-586082122
SonarCloud Quality Gate failed.
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='1.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1946&metric=new_coverage&view=list) [1.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1946&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/5.png' alt='3.6%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1946&metric=new_duplicated_lines_density&view=list) [3.6% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1946&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on
issue #1946: Refactor Architecture Basic modification #1658
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on issue #1946: Refactor Architecture Basic modification #1658
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946#issuecomment-585760456
SonarCloud Quality Gate failed.
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='1.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1946&metric=new_coverage&view=list) [1.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1946&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/5.png' alt='3.6%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1946&metric=new_duplicated_lines_density&view=list) [3.6% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1946&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1946: Refactor Architecture Basic modification #1658
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1946: Refactor Architecture Basic modification #1658
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946#issuecomment-585172652
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=h1) Report
> Merging [#1946](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/fb5de1784e22072d0597e51d6c7de5a6c126bfbf?src=pr&el=desc) will **increase** coverage by `0.45%`.
> The diff coverage is `48.93%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1946 +/- ##
============================================
+ Coverage 28.57% 29.03% +0.45%
- Complexity 1295 1314 +19
============================================
Files 294 294
Lines 14985 14989 +4
Branches 1808 1810 +2
============================================
+ Hits 4282 4352 +70
+ Misses 10272 10202 -70
- Partials 431 435 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...hinscheduler/dao/datasource/ConnectionFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvQ29ubmVjdGlvbkZhY3RvcnkuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...e/dolphinscheduler/server/worker/WorkerServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9Xb3JrZXJTZXJ2ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...er/server/worker/task/AbstractCommandExecutor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL0Fic3RyYWN0Q29tbWFuZEV4ZWN1dG9yLmphdmE=) | `40.1% <0%> (ø)` | `14 <0> (ø)` | :arrow_down: |
| [...apache/dolphinscheduler/alert/utils/Constants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9Db25zdGFudHMuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...he/dolphinscheduler/server/utils/ProcessUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1Byb2Nlc3NVdGlscy5qYXZh) | `16.54% <0%> (-0.5%)` | `8 <0> (ø)` | |
| [.../apache/dolphinscheduler/api/utils/CheckUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3V0aWxzL0NoZWNrVXRpbHMuamF2YQ==) | `61.53% <0%> (+9.53%)` | `19 <0> (+3)` | :arrow_up: |
| [...dolphinscheduler/api/service/ResourcesService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUmVzb3VyY2VzU2VydmljZS5qYXZh) | `79.66% <0%> (ø)` | `67 <0> (ø)` | :arrow_down: |
| [...r/common/task/subprocess/SubProcessParameters.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svc3VicHJvY2Vzcy9TdWJQcm9jZXNzUGFyYW1ldGVycy5qYXZh) | `16.66% <0%> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [...che/dolphinscheduler/common/utils/CommonUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0NvbW1vblV0aWxzLmphdmE=) | `40% <0%> (+40%)` | `5 <0> (+5)` | :arrow_up: |
| [...scheduler/dao/datasource/ClickHouseDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvQ2xpY2tIb3VzZURhdGFTb3VyY2UuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| ... and [13 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=footer). Last update [fb5de17...822b9b4](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue
#1946: Refactor Architecture Basic modification #1658
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on issue #1946: Refactor Architecture Basic modification #1658
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946#issuecomment-585760456
SonarCloud Quality Gate failed.
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='1.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1946&metric=new_coverage&view=list) [1.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1946&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/5.png' alt='3.6%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1946&metric=new_duplicated_lines_density&view=list) [3.6% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1946&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue
#1946: Refactor Architecture Basic modification #1658
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on issue #1946: Refactor Architecture Basic modification #1658
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946#issuecomment-585174053
SonarCloud Quality Gate failed.
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='0.7%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1946&metric=new_coverage&view=list) [0.7% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1946&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/5.png' alt='3.2%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1946&metric=new_duplicated_lines_density&view=list) [3.2% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1946&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1946:
Refactor Architecture Basic modification #1658
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1946: Refactor Architecture Basic modification #1658
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946#issuecomment-585172652
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=h1) Report
> Merging [#1946](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/768b5d9dfdbf4b9397f958713b950d9b5583205a?src=pr&el=desc) will **increase** coverage by `1.78%`.
> The diff coverage is `8%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1946 +/- ##
============================================
+ Coverage 26.78% 28.57% +1.78%
+ Complexity 1364 1295 -69
============================================
Files 312 294 -18
Lines 16645 14985 -1660
Branches 2049 1808 -241
============================================
- Hits 4459 4282 -177
+ Misses 11710 10272 -1438
+ Partials 476 431 -45
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...nscheduler/dao/datasource/SQLServerDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvU1FMU2VydmVyRGF0YVNvdXJjZS5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [...hinscheduler/dao/datasource/PostgreDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvUG9zdGdyZURhdGFTb3VyY2UuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [...phinscheduler/dao/datasource/OracleDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvT3JhY2xlRGF0YVNvdXJjZS5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [...dolphinscheduler/server/monitor/ZKMonitorImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21vbml0b3IvWktNb25pdG9ySW1wbC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...olphinscheduler/dao/datasource/HiveDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvSGl2ZURhdGFTb3VyY2UuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [...uler/api/controller/ProcessInstanceController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvUHJvY2Vzc0luc3RhbmNlQ29udHJvbGxlci5qYXZh) | `2.43% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: |
| [...hinscheduler/dao/datasource/DataSourceFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvRGF0YVNvdXJjZUZhY3RvcnkuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [...e/dolphinscheduler/common/utils/Preconditions.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1ByZWNvbmRpdGlvbnMuamF2YQ==) | `0% <ø> (-63.16%)` | `0 <0> (-20)` | |
| [...scheduler/dao/datasource/ClickHouseDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvQ2xpY2tIb3VzZURhdGFTb3VyY2UuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [...he/dolphinscheduler/server/utils/RemoveZKNode.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1JlbW92ZVpLTm9kZS5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| ... and [43 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=footer). Last update [768b5d9...fb5de17](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on
issue #1946: Refactor Architecture Basic modification #1658
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on issue #1946: Refactor Architecture Basic modification #1658
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946#issuecomment-585664419
SonarCloud Quality Gate failed.
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1946&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='0.7%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1946&metric=new_coverage&view=list) [0.7% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1946&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/5.png' alt='3.6%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1946&metric=new_duplicated_lines_density&view=list) [3.6% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1946&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] qiaozhanwei commented on issue #1946:
Refactor Architecture Basic modification #1658
Posted by GitBox <gi...@apache.org>.
qiaozhanwei commented on issue #1946: Refactor Architecture Basic modification #1658
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946#issuecomment-585618004
remote module already add comment , please review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services