You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/12/23 23:04:36 UTC
Review Request 29380: Added resource operations to the launchTasks
API.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29380/
-----------------------------------------------------------
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, switched to 'mcypark', and Vinod Kone.
Repository: mesos-git
Description
-------
Added resource operations to the launchTasks API.
See details in
https://reviews.apache.org/r/29173/
The reason for introducing resource operations while launching task is to allow frameworks to transform the offered resources for persistent disk and dynamic reservation. We want the framework to explicitly set them so that it causes less confusion to the master (master no long needs to infer resource transformations which sometimes are ambiguate).
Diffs
-----
include/mesos/scheduler.hpp 42e4e279d059801cd85955fd04995b60051a2b5e
include/mesos/scheduler/scheduler.proto 5491c59e7addda0ee5d95a019d7eaeb953ca82e4
src/master/master.hpp 26116aff1e965501c8d94ea0b5bd1be37f944887
src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
src/messages/messages.proto 16043dd934cbfc1159dad7adf366dfbfcc5a077b
src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
Diff: https://reviews.apache.org/r/29380/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 29380: Added resource operations to the
launchTasks API.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29380/#review65991
-----------------------------------------------------------
include/mesos/scheduler.hpp
<https://reviews.apache.org/r/29380/#comment109294>
Would we possibly want to apply any operations after launching the task? Or after the task completes/fails? (e.g. release a temporary volume, unreserve resources)
include/mesos/scheduler.hpp
<https://reviews.apache.org/r/29380/#comment109295>
Maybe name this "preparations" or "prerequisites" to emphasize that these are operations that are applied to the resources before launching the task(s).
include/mesos/scheduler/scheduler.proto
<https://reviews.apache.org/r/29380/#comment109296>
Again, what specifies when these operations occur? `prelaunch_operations`?
- Adam B
On Dec. 23, 2014, 2:04 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29380/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2014, 2:04 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, switched to 'mcypark', and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added resource operations to the launchTasks API.
>
> See details in
> https://reviews.apache.org/r/29173/
>
> The reason for introducing resource operations while launching task is to allow frameworks to transform the offered resources for persistent disk and dynamic reservation. We want the framework to explicitly set them so that it causes less confusion to the master (master no long needs to infer resource transformations which sometimes are ambiguate).
>
>
> Diffs
> -----
>
> include/mesos/scheduler.hpp 42e4e279d059801cd85955fd04995b60051a2b5e
> include/mesos/scheduler/scheduler.proto 5491c59e7addda0ee5d95a019d7eaeb953ca82e4
> src/master/master.hpp 26116aff1e965501c8d94ea0b5bd1be37f944887
> src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
> src/messages/messages.proto 16043dd934cbfc1159dad7adf366dfbfcc5a077b
> src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
> src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
>
> Diff: https://reviews.apache.org/r/29380/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 29380: Added resource operations to the
launchTasks API.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29380/#review65977
-----------------------------------------------------------
Patch looks great!
Reviews applied: [29274, 29380]
All tests passed.
- Mesos ReviewBot
On Dec. 23, 2014, 10:04 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29380/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2014, 10:04 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, switched to 'mcypark', and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added resource operations to the launchTasks API.
>
> See details in
> https://reviews.apache.org/r/29173/
>
> The reason for introducing resource operations while launching task is to allow frameworks to transform the offered resources for persistent disk and dynamic reservation. We want the framework to explicitly set them so that it causes less confusion to the master (master no long needs to infer resource transformations which sometimes are ambiguate).
>
>
> Diffs
> -----
>
> include/mesos/scheduler.hpp 42e4e279d059801cd85955fd04995b60051a2b5e
> include/mesos/scheduler/scheduler.proto 5491c59e7addda0ee5d95a019d7eaeb953ca82e4
> src/master/master.hpp 26116aff1e965501c8d94ea0b5bd1be37f944887
> src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
> src/messages/messages.proto 16043dd934cbfc1159dad7adf366dfbfcc5a077b
> src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
> src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
>
> Diff: https://reviews.apache.org/r/29380/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 29380: Added resource transformations to the
launchTasks API.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29380/#review66781
-----------------------------------------------------------
Patch looks great!
Reviews applied: [29274, 29380]
All tests passed.
- Mesos ReviewBot
On Jan. 6, 2015, 12:45 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29380/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2015, 12:45 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, switched to 'mcypark', and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added resource operations to the launchTasks API.
>
> See details in
> https://reviews.apache.org/r/29173/
>
> The reason for introducing resource operations while launching task is to allow frameworks to transform the offered resources for persistent disk and dynamic reservation. We want the framework to explicitly set them so that it causes less confusion to the master (master no long needs to infer resource transformations which sometimes are ambiguate).
>
>
> Diffs
> -----
>
> include/mesos/scheduler.hpp 42e4e279d059801cd85955fd04995b60051a2b5e
> include/mesos/scheduler/scheduler.proto 5491c59e7addda0ee5d95a019d7eaeb953ca82e4
> src/master/master.hpp 26116aff1e965501c8d94ea0b5bd1be37f944887
> src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
> src/messages/messages.proto 16043dd934cbfc1159dad7adf366dfbfcc5a077b
> src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
> src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
>
> Diff: https://reviews.apache.org/r/29380/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 29380: Added resource transformations to the
launchTasks API.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29380/
-----------------------------------------------------------
(Updated Jan. 6, 2015, 12:45 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, switched to 'mcypark', and Vinod Kone.
Changes
-------
Haven't addressed the review comments yet. Try to unblock mpark.
Summary (updated)
-----------------
Added resource transformations to the launchTasks API.
Repository: mesos-git
Description
-------
Added resource operations to the launchTasks API.
See details in
https://reviews.apache.org/r/29173/
The reason for introducing resource operations while launching task is to allow frameworks to transform the offered resources for persistent disk and dynamic reservation. We want the framework to explicitly set them so that it causes less confusion to the master (master no long needs to infer resource transformations which sometimes are ambiguate).
Diffs (updated)
-----
include/mesos/scheduler.hpp 42e4e279d059801cd85955fd04995b60051a2b5e
include/mesos/scheduler/scheduler.proto 5491c59e7addda0ee5d95a019d7eaeb953ca82e4
src/master/master.hpp 26116aff1e965501c8d94ea0b5bd1be37f944887
src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
src/messages/messages.proto 16043dd934cbfc1159dad7adf366dfbfcc5a077b
src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
Diff: https://reviews.apache.org/r/29380/diff/
Testing
-------
make check
Thanks,
Jie Yu