You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/02/08 11:00:34 UTC

[GitHub] [superset] ad-m opened a new pull request #18619: fix(helm): Fix support for ingress.ingressClassName

ad-m opened a new pull request #18619:
URL: https://github.com/apache/superset/pull/18619


   
   ### SUMMARY
   
   In #18617 @joatkh reported removed support for `ingress.ingressClassName` in `values.yaml` of our Chart. It is an undocumented parameter but supported by our Chart:
   https://github.com/apache/superset/blob/1fbdabd2cf88ce4da0b99897ce00afd03ae47d27/helm/superset/templates/ingress.yaml#L33-L35
   
   That PR re-add that support.
    
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   N/A
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   Use ingress.ingressClassName eg. via `--set` during installation. It should pass validation.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue: #18617
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   @joatkh could you give a shoot to test if it's working for you?
   @craig-rueda could you take a look as maintainer of Chart?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] craig-rueda merged pull request #18619: fix(helm): Fix support for ingress.ingressClassName

Posted by GitBox <gi...@apache.org>.
craig-rueda merged pull request #18619:
URL: https://github.com/apache/superset/pull/18619


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org