[GitHub] [ozone] sodonnel commented on a diff in pull request #3542: HDDS-6894. EC: ReplicationManager - Add class to handle under-replication and form a command for a datanode

[GitBox <gi...@apache.org>]

sodonnel commented on code in PR #3542:
URL: https://github.com/apache/ozone/pull/3542#discussion_r905959715


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ECContainerReplicaCount.java:
##########
@@ -68,16 +70,27 @@ public class ECContainerReplicaCount {
   private final Map<Integer, Integer> healthyIndexes = new HashMap<>();
   private final Map<Integer, Integer> decommissionIndexes = new HashMap<>();
   private final Map<Integer, Integer> maintenanceIndexes = new HashMap<>();
+  private final Set<ContainerReplica> replicas;
 
   public ECContainerReplicaCount(ContainerInfo containerInfo,
-      Set<ContainerReplica> replicas, List<Integer> indexesPendingAdd,
-      List<Integer> indexesPendingDelete, int remainingMaintenanceRedundancy) {
+      Set<ContainerReplica> replicas,
+      final ContainerReplicaPendingOps pendingOps,

Review Comment:
   I don't think we should pass the instance of ContainerReplicaPending ops in here, as it makes this class dependent on it. Rather we should pass in the list of ops which were returned from the ContainerReplicaPendingOps instance in RM. Ie the parameter is List<ContainerReplicaOp>.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org