You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "xanderbailey (via GitHub)" <gi...@apache.org> on 2025/12/05 18:46:19 UTC
[PR] Allow flag to alias all prjected substrait expressions with a UUID [datafusion]
xanderbailey opened a new pull request, #19123:
URL: https://github.com/apache/datafusion/pull/19123
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
- Closes #.
## Rationale for this change
As previously discussed in https://github.com/apache/datafusion/pull/17299. This continues to be a bit of a thorn for expressions that are the same on the left and the right side of the of a join leading to
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Allow flag to alias all projected substrait expressions with a UUID [datafusion]
Posted by "LiaCastaneda (via GitHub)" <gi...@apache.org>.
LiaCastaneda commented on PR #19123:
URL: https://github.com/apache/datafusion/pull/19123#issuecomment-3669742045
👋 Sorry for the late reply,
I think this fixes all the issues once for all, however I'm wondering if maybe it would be worth it to make this fix in the name tracker instead? as suggested in https://github.com/apache/datafusion/issues/17508. From my understanding what would have to be done is basically track two fields which are the schema name and the qualified name.
cc @dd-annarose since you were looking into this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Allow flag to alias all projected substrait expressions with a UUID [datafusion]
Posted by "xanderbailey (via GitHub)" <gi...@apache.org>.
xanderbailey commented on PR #19123:
URL: https://github.com/apache/datafusion/pull/19123#issuecomment-3761053410
Had a go at the fix here https://github.com/apache/datafusion/pull/19856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Allow flag to alias all projected substrait expressions with a UUID [datafusion]
Posted by "xanderbailey (via GitHub)" <gi...@apache.org>.
xanderbailey closed pull request #19123: Allow flag to alias all projected substrait expressions with a UUID
URL: https://github.com/apache/datafusion/pull/19123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Allow flag to alias all prjected substrait expressions with a UUID [datafusion]
Posted by "xanderbailey (via GitHub)" <gi...@apache.org>.
xanderbailey commented on code in PR #19123:
URL: https://github.com/apache/datafusion/pull/19123#discussion_r2593812868
##########
datafusion/substrait/tests/cases/logical_plans.rs:
##########
@@ -185,6 +186,81 @@ mod tests {
Ok(())
}
+ #[tokio::test]
+ async fn alias_all_expressions_flag() -> Result<()> {
Review Comment:
Happy to take ideas on the best way to write this test but I wanted to show that the UUIDs actually light up correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Allow flag to alias all projected substrait expressions with a UUID [datafusion]
Posted by "xanderbailey (via GitHub)" <gi...@apache.org>.
xanderbailey commented on PR #19123:
URL: https://github.com/apache/datafusion/pull/19123#issuecomment-3646294531
@LiaCastaneda thought you might have some ideas here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Allow flag to alias all projected substrait expressions with a UUID [datafusion]
Posted by "xanderbailey (via GitHub)" <gi...@apache.org>.
xanderbailey commented on PR #19123:
URL: https://github.com/apache/datafusion/pull/19123#issuecomment-3678069963
I'm happy if there's a better route forward we're just looking for a quick fix without having to fork the whole substrait conversation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org