You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by tripodsan <gi...@git.apache.org> on 2015/08/26 09:51:35 UTC
[GitHub] cordova-plugin-file pull request: Cb 9544
GitHub user tripodsan opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/130
Cb 9544
This PR implements the file plugin for OSX.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tripodsan/cordova-plugin-file CB-9544
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file/pull/130.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #130
----
commit 46b2fc4522007f584d0e6574c32baef15f5d8145
Author: Tobias Bocanegra <tr...@adobe.com>
Date: 2015-08-26T01:08:50Z
@trivial - typo
commit df6ba04d5fa7b76dd929eacc5f982322e0593d57
Author: Tobias Bocanegra <tr...@adobe.com>
Date: 2015-08-26T01:09:47Z
CB-9544 Add file plugin for OSX
- adding osx specific sources
- adding osx to plugin.xml and package.json
commit b505412590fb7b84345ef7c6d8c7af661c62d475
Author: Tobias Bocanegra <tr...@adobe.com>
Date: 2015-08-26T07:49:53Z
CB-9544 Add file plugin for OSX
- defining osx filesystems roots
- updating readme to include osx
- updating test case for osx
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Cb 9544
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/130#issuecomment-135200565
Merged in, but did not auto-close, so if you can close this that would be great.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Cb 9544
Posted by tripodsan <gi...@git.apache.org>.
Github user tripodsan commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/130#issuecomment-135215864
thanks. there is a last change regarding the location of the applicationDirectory. this needs to point to the resource path of the application, so that the 'www' directory is directly underneath.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Cb 9544
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/130
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org