You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oodt.apache.org by Radu Manole <ma...@gmail.com> on 2015/09/04 16:29:34 UTC
Re: Review Request 37705: Full implementation of Avro RPC cas-workflow
module.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37705/
-----------------------------------------------------------
(Updated Sept. 4, 2015, 2:29 p.m.)
Review request for oodt, Lewis McGibbney and Chris Mattmann.
Changes
-------
Change the structure of workflow client/server, now it can be configurated in properties file what implementation should be used.
Repository: oodt
Description
-------
Extracted interfaces from workflow server and client, and created Avro RPC base communication. Created Avro types for transmision, and a factory that manages trasformation from avro type to oodt type. Scrips now use Avro rpc.
Diffs (updated)
-----
trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/action/WorkflowMgrStatusUpdate.java 1693501
trunk/mvn/archetypes/radix/src/main/resources/archetype-resources/workflow/src/main/resources/bin/wmgr 1693501
trunk/mvn/archetypes/radix/src/main/resources/archetype-resources/workflow/src/main/resources/bin/wmgr-client 1693501
trunk/pcs/core/src/main/java/org/apache/oodt/pcs/util/WorkflowManagerUtils.java 1693501
trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1693501
trunk/pge/src/test/java/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1693501
trunk/webapp/components/src/main/java/org/apache/oodt/cas/webcomponents/workflow/WorkflowMgrConn.java 1693501
trunk/workflow/pom.xml 1693501
trunk/workflow/src/main/avro/types/AvroWorkflow.avsc PRE-CREATION
trunk/workflow/src/main/avro/types/AvroWorkflowCondition.avsc PRE-CREATION
trunk/workflow/src/main/avro/types/AvroWorkflowInstance.avsc PRE-CREATION
trunk/workflow/src/main/avro/types/AvroWorkflowInstancePage.avsc PRE-CREATION
trunk/workflow/src/main/avro/types/AvroWorkflowTask.avsc PRE-CREATION
trunk/workflow/src/main/avro/types/protocol.avdl PRE-CREATION
trunk/workflow/src/main/bin/wmgr 1693501
trunk/workflow/src/main/bin/wmgr-client 1693501
trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetFirstPageCliAction.java 1693501
trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetLastPageCliAction.java 1693501
trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetNextPageCliAction.java 1693501
trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetPrevPageCliAction.java 1693501
trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetWorkflowInstCliAction.java 1693501
trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetWorkflowInstsCliAction.java 1693501
trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/WorkflowCliAction.java 1693501
trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/examples/BranchRedirector.java 1693501
trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/examples/RandomStatusUpdateTask.java 1693501
trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/TaskJob.java 1693501
trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/WorkflowInstancePage.java 1693501
trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/AvroRpcWorkflowManager.java PRE-CREATION
trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/AvroRpcWorkflowManagerClient.java PRE-CREATION
trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/WorkflowManager.java PRE-CREATION
trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/WorkflowManagerClient.java PRE-CREATION
trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/WorkflowManagerClientStarter.java PRE-CREATION
trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/WorkflowManagerStarter.java PRE-CREATION
trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/XmlRpcWorkflowManager.java 1693501
trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/XmlRpcWorkflowManagerClient.java 1693501
trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/rpc/AvroRpcWorkflowManagerFactory.java PRE-CREATION
trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/rpc/RpcCommunicationFactory.java PRE-CREATION
trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/rpc/WorkflowManagerFactory.java PRE-CREATION
trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/rpc/XmlRpcWorkflowManagerFactory.java PRE-CREATION
trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/tools/InstanceRepoCleaner.java 1693501
trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/util/AvroTypeFactory.java PRE-CREATION
trunk/workflow/src/main/resources/workflow.properties 1693501
trunk/workflow/src/test/java/org/apache/oodt/cas/workflow/cli/TestWorkflowCli.java 1693501
trunk/workflow/src/test/java/org/apache/oodt/cas/workflow/cli/UseMockClientCmdLineActionStore.java 1693501
trunk/workflow/src/test/java/org/apache/oodt/cas/workflow/system/MockWorkflowManagerClient.java PRE-CREATION
trunk/workflow/src/test/java/org/apache/oodt/cas/workflow/system/TestAvroRpcWorkflowManager.java PRE-CREATION
trunk/workflow/src/test/java/org/apache/oodt/cas/workflow/system/TestWorkflowManagerClient.java PRE-CREATION
Diff: https://reviews.apache.org/r/37705/diff/
Testing
-------
Uses existing tests and create tests for Avro RPC. Tested Avro type factory. Used user guide and build and run workflow server, sending an event.
Thanks,
Radu Manole
Re: Review Request 37705: Full implementation of Avro RPC cas-workflow
module.
Posted by Lewis McGibbney <le...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37705/#review99159
-----------------------------------------------------------
Ship it!
Ship It!
- Lewis McGibbney
On Sept. 4, 2015, 2:29 p.m., Radu Manole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37705/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2015, 2:29 p.m.)
>
>
> Review request for oodt, Lewis McGibbney and Chris Mattmann.
>
>
> Repository: oodt
>
>
> Description
> -------
>
> Extracted interfaces from workflow server and client, and created Avro RPC base communication. Created Avro types for transmision, and a factory that manages trasformation from avro type to oodt type. Scrips now use Avro rpc.
>
>
> Diffs
> -----
>
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/action/WorkflowMgrStatusUpdate.java 1693501
> trunk/mvn/archetypes/radix/src/main/resources/archetype-resources/workflow/src/main/resources/bin/wmgr 1693501
> trunk/mvn/archetypes/radix/src/main/resources/archetype-resources/workflow/src/main/resources/bin/wmgr-client 1693501
> trunk/pcs/core/src/main/java/org/apache/oodt/pcs/util/WorkflowManagerUtils.java 1693501
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1693501
> trunk/pge/src/test/java/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1693501
> trunk/webapp/components/src/main/java/org/apache/oodt/cas/webcomponents/workflow/WorkflowMgrConn.java 1693501
> trunk/workflow/pom.xml 1693501
> trunk/workflow/src/main/avro/types/AvroWorkflow.avsc PRE-CREATION
> trunk/workflow/src/main/avro/types/AvroWorkflowCondition.avsc PRE-CREATION
> trunk/workflow/src/main/avro/types/AvroWorkflowInstance.avsc PRE-CREATION
> trunk/workflow/src/main/avro/types/AvroWorkflowInstancePage.avsc PRE-CREATION
> trunk/workflow/src/main/avro/types/AvroWorkflowTask.avsc PRE-CREATION
> trunk/workflow/src/main/avro/types/protocol.avdl PRE-CREATION
> trunk/workflow/src/main/bin/wmgr 1693501
> trunk/workflow/src/main/bin/wmgr-client 1693501
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetFirstPageCliAction.java 1693501
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetLastPageCliAction.java 1693501
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetNextPageCliAction.java 1693501
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetPrevPageCliAction.java 1693501
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetWorkflowInstCliAction.java 1693501
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetWorkflowInstsCliAction.java 1693501
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/WorkflowCliAction.java 1693501
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/examples/BranchRedirector.java 1693501
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/examples/RandomStatusUpdateTask.java 1693501
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/TaskJob.java 1693501
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/WorkflowInstancePage.java 1693501
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/AvroRpcWorkflowManager.java PRE-CREATION
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/AvroRpcWorkflowManagerClient.java PRE-CREATION
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/WorkflowManager.java PRE-CREATION
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/WorkflowManagerClient.java PRE-CREATION
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/WorkflowManagerClientStarter.java PRE-CREATION
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/WorkflowManagerStarter.java PRE-CREATION
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/XmlRpcWorkflowManager.java 1693501
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/XmlRpcWorkflowManagerClient.java 1693501
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/rpc/AvroRpcWorkflowManagerFactory.java PRE-CREATION
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/rpc/RpcCommunicationFactory.java PRE-CREATION
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/rpc/WorkflowManagerFactory.java PRE-CREATION
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/rpc/XmlRpcWorkflowManagerFactory.java PRE-CREATION
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/tools/InstanceRepoCleaner.java 1693501
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/util/AvroTypeFactory.java PRE-CREATION
> trunk/workflow/src/main/resources/workflow.properties 1693501
> trunk/workflow/src/test/java/org/apache/oodt/cas/workflow/cli/TestWorkflowCli.java 1693501
> trunk/workflow/src/test/java/org/apache/oodt/cas/workflow/cli/UseMockClientCmdLineActionStore.java 1693501
> trunk/workflow/src/test/java/org/apache/oodt/cas/workflow/system/MockWorkflowManagerClient.java PRE-CREATION
> trunk/workflow/src/test/java/org/apache/oodt/cas/workflow/system/TestAvroRpcWorkflowManager.java PRE-CREATION
> trunk/workflow/src/test/java/org/apache/oodt/cas/workflow/system/TestWorkflowManagerClient.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37705/diff/
>
>
> Testing
> -------
>
> Uses existing tests and create tests for Avro RPC. Tested Avro type factory. Used user guide and build and run workflow server, sending an event.
>
>
> Thanks,
>
> Radu Manole
>
>
Re: Review Request 37705: Full implementation of Avro RPC cas-workflow
module.
Posted by Lewis McGibbney <le...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37705/#review97865
-----------------------------------------------------------
When I try to apply this patch against the avro_rpc branch and test it locally I get the following
{code}
[INFO] Catalog and Archive Resource Management Component .. SUCCESS [ 15.281 s]
[INFO] Catalog and Archive Workflow Management Component .. FAILURE [ 2.642 s]
[INFO] Catalog and Archive Crawling Framework ............. SKIPPED
[INFO] CAS Curation Web Services .......................... SKIPPED
[INFO] Process Control System Core Package ................ SKIPPED
[INFO] OODT Wicket Web Components ......................... SKIPPED
[INFO] CAS Curation Interface ............................. SKIPPED
[INFO] CAS PGE Adaptor Framework .......................... SKIPPED
[INFO] CAS Installer Maven Mojo ........................... SKIPPED
[INFO] OODT :: Archetypes :: OpsUI ........................ SKIPPED
[INFO] OODT :: Archetypes :: RADiX ........................ SKIPPED
[INFO] OODT :: Archetypes ................................. SKIPPED
[INFO] CAS Push-Pull-Framework ............................ SKIPPED
[INFO] Product Service .................................... SKIPPED
[INFO] Profile Service .................................... SKIPPED
[INFO] OODT Web Grid ...................................... SKIPPED
[INFO] XML-configured, DBMS-based Product and Profile Server SKIPPED
[INFO] Apache OODT Configurable OPeNDAP Profile Server .... SKIPPED
[INFO] CAS File Manager Browser Web App ................... SKIPPED
[INFO] CAS Product Server Web Application ................. SKIPPED
[INFO] CAS Workflow Manager Monitor Web App ............... SKIPPED
[INFO] Catalog and Archive File Management Browser ........ SKIPPED
[INFO] Catalog and Archive Workflow Management GUI Editor . SKIPPED
[INFO] Process Control System Operator Interface Webapp ... SKIPPED
[INFO] OODT Process Control System JAX-RS service layer ... SKIPPED
[INFO] Apache OODT ........................................ SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:23 min
[INFO] Finished at: 2015-09-05T10:34:54-04:00
[INFO] Final Memory: 69M/326M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project cas-workflow: Compilation failure: Compilation failure:
[ERROR] /usr/local/avro_cas_workflow/workflow/src/main/java/org/apache/oodt/cas/workflow/system/AvroRpcWorkflowManager.java:[267,56] incompatible types
[ERROR] required: java.util.List<org.apache.oodt.cas.workflow.struct.avrotypes.AvroWorkflowInstance>
[ERROR] found: java.util.List<org.apache.oodt.cas.workflow.struct.avrotypes.AvroWorkflow>
[ERROR] /usr/local/avro_cas_workflow/workflow/src/main/java/org/apache/oodt/cas/workflow/system/AvroRpcWorkflowManager.java:[510,52] incompatible types
[ERROR] required: java.util.List<org.apache.oodt.cas.workflow.struct.avrotypes.AvroWorkflow>
[ERROR] found: java.util.List<org.apache.oodt.cas.workflow.structs.Workflow>
[ERROR] -> [Help 1]
{code}
It seems there are some Type issues within the newly introduced classes. Can you investigate?
- Lewis McGibbney
On Sept. 4, 2015, 2:29 p.m., Radu Manole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37705/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2015, 2:29 p.m.)
>
>
> Review request for oodt, Lewis McGibbney and Chris Mattmann.
>
>
> Repository: oodt
>
>
> Description
> -------
>
> Extracted interfaces from workflow server and client, and created Avro RPC base communication. Created Avro types for transmision, and a factory that manages trasformation from avro type to oodt type. Scrips now use Avro rpc.
>
>
> Diffs
> -----
>
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/action/WorkflowMgrStatusUpdate.java 1693501
> trunk/mvn/archetypes/radix/src/main/resources/archetype-resources/workflow/src/main/resources/bin/wmgr 1693501
> trunk/mvn/archetypes/radix/src/main/resources/archetype-resources/workflow/src/main/resources/bin/wmgr-client 1693501
> trunk/pcs/core/src/main/java/org/apache/oodt/pcs/util/WorkflowManagerUtils.java 1693501
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1693501
> trunk/pge/src/test/java/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1693501
> trunk/webapp/components/src/main/java/org/apache/oodt/cas/webcomponents/workflow/WorkflowMgrConn.java 1693501
> trunk/workflow/pom.xml 1693501
> trunk/workflow/src/main/avro/types/AvroWorkflow.avsc PRE-CREATION
> trunk/workflow/src/main/avro/types/AvroWorkflowCondition.avsc PRE-CREATION
> trunk/workflow/src/main/avro/types/AvroWorkflowInstance.avsc PRE-CREATION
> trunk/workflow/src/main/avro/types/AvroWorkflowInstancePage.avsc PRE-CREATION
> trunk/workflow/src/main/avro/types/AvroWorkflowTask.avsc PRE-CREATION
> trunk/workflow/src/main/avro/types/protocol.avdl PRE-CREATION
> trunk/workflow/src/main/bin/wmgr 1693501
> trunk/workflow/src/main/bin/wmgr-client 1693501
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetFirstPageCliAction.java 1693501
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetLastPageCliAction.java 1693501
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetNextPageCliAction.java 1693501
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetPrevPageCliAction.java 1693501
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetWorkflowInstCliAction.java 1693501
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetWorkflowInstsCliAction.java 1693501
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/WorkflowCliAction.java 1693501
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/examples/BranchRedirector.java 1693501
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/examples/RandomStatusUpdateTask.java 1693501
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/TaskJob.java 1693501
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/WorkflowInstancePage.java 1693501
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/AvroRpcWorkflowManager.java PRE-CREATION
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/AvroRpcWorkflowManagerClient.java PRE-CREATION
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/WorkflowManager.java PRE-CREATION
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/WorkflowManagerClient.java PRE-CREATION
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/WorkflowManagerClientStarter.java PRE-CREATION
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/WorkflowManagerStarter.java PRE-CREATION
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/XmlRpcWorkflowManager.java 1693501
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/XmlRpcWorkflowManagerClient.java 1693501
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/rpc/AvroRpcWorkflowManagerFactory.java PRE-CREATION
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/rpc/RpcCommunicationFactory.java PRE-CREATION
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/rpc/WorkflowManagerFactory.java PRE-CREATION
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/rpc/XmlRpcWorkflowManagerFactory.java PRE-CREATION
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/tools/InstanceRepoCleaner.java 1693501
> trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/util/AvroTypeFactory.java PRE-CREATION
> trunk/workflow/src/main/resources/workflow.properties 1693501
> trunk/workflow/src/test/java/org/apache/oodt/cas/workflow/cli/TestWorkflowCli.java 1693501
> trunk/workflow/src/test/java/org/apache/oodt/cas/workflow/cli/UseMockClientCmdLineActionStore.java 1693501
> trunk/workflow/src/test/java/org/apache/oodt/cas/workflow/system/MockWorkflowManagerClient.java PRE-CREATION
> trunk/workflow/src/test/java/org/apache/oodt/cas/workflow/system/TestAvroRpcWorkflowManager.java PRE-CREATION
> trunk/workflow/src/test/java/org/apache/oodt/cas/workflow/system/TestWorkflowManagerClient.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37705/diff/
>
>
> Testing
> -------
>
> Uses existing tests and create tests for Avro RPC. Tested Avro type factory. Used user guide and build and run workflow server, sending an event.
>
>
> Thanks,
>
> Radu Manole
>
>