[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4741: VM has wrong network statistics with multiple nics in shared networks

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #4741:
URL: https://github.com/apache/cloudstack/pull/4741#discussion_r588374510



##########
File path: usage/src/main/java/com/cloud/usage/parser/NetworkUsageParser.java
##########
@@ -80,7 +80,7 @@ public static boolean parse(AccountVO account, Date startDate, Date endDate) {
             long zoneId = usageNetwork.getZoneId();
             String key = "" + zoneId;
             if (usageNetwork.getHostId() != 0) {
-                key += "-Host" + usageNetwork.getHostId();
+                key += "-Host" + usageNetwork.getHostId() + "-Network-" + usageNetwork.getNetworkId();

Review comment:
       should networkid be checked for 0 as well?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org