You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by jatin9896 <gi...@git.apache.org> on 2018/07/04 14:26:34 UTC
[GitHub] carbondata pull request #2448: [HotFix] Getting carbon table identifier to d...
GitHub user jatin9896 opened a pull request:
https://github.com/apache/carbondata/pull/2448
[HotFix] Getting carbon table identifier to datamap events
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed? NO
- [ ] Any backward compatibility impacted? NO
- [ ] Document update required? NO
- [ ] Testing done NA
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jatin9896/incubator-carbondata hotfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2448.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2448
----
commit c0d23c8d6529fff5af8bcb8730c817d75e5da1ca
Author: Jatin <ja...@...>
Date: 2018-07-04T14:23:48Z
getting carbon table identifier to datamap events
----
---
[GitHub] carbondata issue #2448: [HotFix] Getting carbon table identifier to datamap ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2448
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5693/
---
[GitHub] carbondata pull request #2448: [HotFix] Getting carbon table identifier to d...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2448#discussion_r200258280
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/datamap/CarbonDropDataMapCommand.scala ---
@@ -201,12 +201,12 @@ case class CarbonDropDataMapCommand(
val operationContext: OperationContext = new OperationContext()
val systemFolderLocation: String = CarbonProperties.getInstance().getSystemFolderLocation
val updateDataMapPreExecutionEvent: UpdateDataMapPreExecutionEvent =
- UpdateDataMapPreExecutionEvent(sparkSession, systemFolderLocation)
+ UpdateDataMapPreExecutionEvent(sparkSession, systemFolderLocation, table.get)
OperationListenerBus.getInstance().fireEvent(updateDataMapPreExecutionEvent,
operationContext)
DataMapStatusManager.dropDataMap(dataMapSchema.getDataMapName)
val updateDataMapPostExecutionEvent: UpdateDataMapPostExecutionEvent =
- UpdateDataMapPostExecutionEvent(sparkSession, systemFolderLocation)
+ UpdateDataMapPostExecutionEvent(sparkSession, systemFolderLocation,table.get)
--- End diff --
need a space after comma
---
[GitHub] carbondata issue #2448: [HotFix] Getting carbon table identifier to datamap ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2448
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5877/
---
[GitHub] carbondata issue #2448: [HotFix] Getting carbon table identifier to datamap ...
Posted by jatin9896 <gi...@git.apache.org>.
Github user jatin9896 commented on the issue:
https://github.com/apache/carbondata/pull/2448
retest sdv please
---
[GitHub] carbondata issue #2448: [HotFix] Getting carbon table identifier to datamap ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2448
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5957/
---
[GitHub] carbondata issue #2448: [HotFix] Getting carbon table identifier to datamap ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2448
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6800/
---
[GitHub] carbondata issue #2448: [HotFix] Getting carbon table identifier to datamap ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2448
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7101/
---
[GitHub] carbondata issue #2448: [HotFix] Getting carbon table identifier to datamap ...
Posted by jatin9896 <gi...@git.apache.org>.
Github user jatin9896 commented on the issue:
https://github.com/apache/carbondata/pull/2448
retest sdv please
---
[GitHub] carbondata issue #2448: [HotFix] Getting carbon table identifier to datamap ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2448
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5646/
---
[GitHub] carbondata issue #2448: [HotFix] Getting carbon table identifier to datamap ...
Posted by jatin9896 <gi...@git.apache.org>.
Github user jatin9896 commented on the issue:
https://github.com/apache/carbondata/pull/2448
retest this please
---
[GitHub] carbondata issue #2448: [HotFix] Getting carbon table identifier to datamap ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2448
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5842/
---
[GitHub] carbondata issue #2448: [HotFix] Getting carbon table identifier to datamap ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2448
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5674/
---
[GitHub] carbondata issue #2448: [HotFix] Getting carbon table identifier to datamap ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2448
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5618/
---
[GitHub] carbondata pull request #2448: [HotFix] Getting carbon table identifier to d...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2448
---
[GitHub] carbondata issue #2448: [HotFix] Getting carbon table identifier to datamap ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2448
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6856/
---
[GitHub] carbondata issue #2448: [HotFix] Getting carbon table identifier to datamap ...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2448
LGTM
---
[GitHub] carbondata issue #2448: [HotFix] Getting carbon table identifier to datamap ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2448
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6908/
---
[GitHub] carbondata issue #2448: [HotFix] Getting carbon table identifier to datamap ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2448
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7181/
---
[GitHub] carbondata issue #2448: [HotFix] Getting carbon table identifier to datamap ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2448
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5840/
---
[GitHub] carbondata issue #2448: [HotFix] Getting carbon table identifier to datamap ...
Posted by jatin9896 <gi...@git.apache.org>.
Github user jatin9896 commented on the issue:
https://github.com/apache/carbondata/pull/2448
retest this please
---
[GitHub] carbondata issue #2448: [HotFix] Getting carbon table identifier to datamap ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2448
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5616/
---
[GitHub] carbondata issue #2448: [HotFix] Getting carbon table identifier to datamap ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2448
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6772/
---
[GitHub] carbondata issue #2448: [HotFix] Getting carbon table identifier to datamap ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2448
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5594/
---
[GitHub] carbondata issue #2448: [HotFix] Getting carbon table identifier to datamap ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2448
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5703/
---